Skip to content

N1qlQueryCreator - IN, NOT IN should not cast parameter to Object[] [DATACOUCH-603] #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Aug 12, 2020 · 0 comments
Closed

N1qlQueryCreator - IN, NOT IN should not cast parameter to Object[] [DATACOUCH-603] #911

spring-projects-issues opened this issue Aug 12, 2020 · 0 comments
Assignees
@mikereiche
Labels
type: enhancement A general enhancement
Milestone
4.1 GA (2020.0.0)

Comments

@spring-projects-issues
Copy link

Michael Reiche opened DATACOUCH-603 and commented

N1qlQueryCreator - IN, NOT IN should not cast parameter to Object[]

List<> and JsonArray should be acceptable as well.   The code should just pass in the argument without any cast and let ParameterAccessor handle it.

case IN:
return criteria.in((Object[]) parameters.next());
case NOT_IN:
return criteria.notIn((Object[]) parameters.next());

Referenced from: pull request #263

Backported to: 4.0.5 (Neumann SR5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikereiche mikereiche

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.1 GA (2020.0.0)
Development

No branches or pull requests
2 participants
@spring-projects-issues @mikereiche