Skip to content

Take expiry from entity class annotation for getAndTouch. #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Take expiry from entity class annotation for getAndTouch. #1640

merged 1 commit into from
Jan 10, 2023

Conversation

mikereiche
Copy link
Collaborator

Closes #1634.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

mikereiche
mikereiche commented Jan 10, 2023
View reviewed changes
Copy link
Collaborator Author

@mikereiche mikereiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgerod @dnault

@mikereiche mikereiche force-pushed the datacouch_1634_take_expiry_from_entity_annotations branch from de7219a to fc48b86 Compare January 10, 2023 18:25
dnault
dnault reviewed Jan 10, 2023
View reviewed changes
src/main/java/org/springframework/data/couchbase/core/ReactiveFindByIdOperationSupport.java
@@ -72,6 +72,8 @@ public <T> ReactiveFindById<T> findById(Class<T> domainType) {
private final ReactiveTemplateSupport support;
private final Duration expiry;

private Duration expiryToUse;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be volatile?

@mikereiche mikereiche merged commit 897d3fc into main Jan 10, 2023
mikereiche added a commit that referenced this pull request Jan 11, 2023
@mikereiche
Take expiry from entity class annotation for getAndTouch. (#1640)
1cfbf0e 
Closes #1634.
mikereiche added a commit that referenced this pull request Jan 11, 2023
@mikereiche
Take expiry from entity class annotation for getAndTouch. (#1640)
7800cf7 
Closes #1634.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnault dnault dnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Never call getAndTouch in ReactiveFindByIdOperationSupport
2 participants
@mikereiche @dnault