Never call getAndTouch in ReactiveFindByIdOperationSupport

[jorgerod]

Hello

I'm trying to do a getAndTouch in the

spring-data-couchbase/src/main/java/org/springframework/data/couchbase/core/ReactiveFindByIdOperationSupport.java

Lines 88 to 90 in d994eb7

	public Mono<T> one(final Object id) {
	CommonOptions<?> gOptions = initGetOptions();

method and I think there is a bug.
The options are never initialized so the get method is always executed.

Related issue: #1196

Thank you very much

[mikereiche]

Can you show the call you are making?

This is the test case for getAndTouch() being used when an expiry is specified.

spring-data-couchbase/src/test/java/org/springframework/data/couchbase/core/CouchbaseTemplateKeyValueIntegrationTests.java

Line 95 in d994eb7

void findByIdWithExpiry() {

[jorgerod]

Hi @mikereiche

Sorry I couldn't answer you before, but I've been busy.

As I understand it, to do getAndTouch you have to take into account touchOnRead property defined in @Document

According to the javadoc of the touchOnRead property in org.springframework.data.couchbase.core.mapping.Document:

An optional flag associated with expiry() indicating whether the expiry timer should be reset whenever the document is directly read (eg. findByOne, findById).

And Spring Data Couchbase is not taking this property into account.
Is this the right behaviour? So, property touchOnRead is useless?

In fact, reviewing Spring Data Couchbase 3x, this property is taken into account (spring-data-couchbase 3.2.9-RELEASE. (Couchbase.java): ):

  @Override
  public <T> T findById(final String id, Class<T> entityClass) {
    final CouchbasePersistentEntity<?> entity = mappingContext.getRequiredPersistentEntity(entityClass);
    RawJsonDocument result = execute(new BucketCallback<RawJsonDocument>() {
      @Override
      public RawJsonDocument doInBucket() {
        if (entity.isTouchOnRead()) {
          return client.getAndTouch(id, entity.getExpiry(), RawJsonDocument.class);
        } else {
          return client.get(id, RawJsonDocument.class);
        }
      }
    });

    return mapToEntity(id, result, entityClass);
  }

Thank you very much

[mikereiche]

Edit: it seems that relying solely on @expiry annotation would not work.

"options are never initialized"

It doesn't need to be initialized. from initGetOptions()

	if (expiry != null || options instanceof GetAndTouchOptions) {
		GetAndTouchOptions gOptions = options != null ? (GetAndTouchOptions) options : getAndTouchOptions();
		if (gOptions.build().transcoder() == null) {
			gOptions.transcoder(RawJsonTranscoder.INSTANCE);
		}
		getOptions = gOptions;

We can go back and forth with you saying that it doesn't work, and me pointing to the test that shows that it does work.
Do you have any new information? Can you provide an example of it not working?

The value comes from expiryToUse() in ReactiveFindByIdOperationSupport.

return rc.getAndTouch(id.toString(), expiryToUse(), (GetAndTouchOptions) pArgs.getOptions())
		.flatMap(result -> support.decodeEntity(id, result.contentAs(String.class), result.cas(), domainType,
				pArgs.getScope(), pArgs.getCollection(), null, null));

private Duration expiryToUse() {
	Duration expiryToUse = expiry; << from withExpiry()
	if (expiryToUse != null || options instanceof GetAndTouchOptions) {
		if (expiryToUse == null) { // GetAndTouchOptions without specifying expiry -> get expiry from annoation
			final CouchbasePersistentEntity<?> entity = template.getConverter().getMappingContext()
					.getRequiredPersistentEntity(domainType);
			expiryToUse = entity.getExpiryDuration();
		}
	}
	return expiryToUse;
}