Skip to content
Closed

Polish #16948

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@
import java.io.IOException;
import java.io.OutputStream;
import java.io.PrintStream;
import java.util.ArrayList;
import java.util.List;

import org.hamcrest.Matcher;
import org.junit.Assert;
import org.junit.jupiter.api.extension.AfterEachCallback;
import org.junit.jupiter.api.extension.BeforeAllCallback;
import org.junit.jupiter.api.extension.BeforeEachCallback;
Expand All @@ -34,12 +30,11 @@

import org.springframework.boot.ansi.AnsiOutput;

import static org.hamcrest.Matchers.allOf;

/**
* JUnit5 {@code @Extension} to capture output from System.out and System.err.
*
* @author Madhura Bhave
* @since 2.2.0
*/
public class OutputCapture implements BeforeEachCallback, AfterEachCallback,
BeforeAllCallback, ParameterResolver, CharSequence {
Expand All @@ -52,20 +47,9 @@ public class OutputCapture implements BeforeEachCallback, AfterEachCallback,

private ByteArrayOutputStream classLevelCopy;

private List<Matcher<? super String>> matchers = new ArrayList<>();

@Override
public void afterEach(ExtensionContext context) {
try {
if (!this.matchers.isEmpty()) {
String output = this.toString();
Assert.assertThat(output, allOf(this.matchers));
}
}
finally {
releaseOutput();
}

releaseOutput();
}

@Override
Expand Down Expand Up @@ -168,11 +152,6 @@ public void write(int b) throws IOException {
this.original.flush();
}

@Override
public void write(byte[] b) throws IOException {
write(b, 0, b.length);
}

@Override
public void write(byte[] b, int off, int len) throws IOException {
this.copy.write(b, off, len);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,19 @@
*/
@ExtendWith(OutputCapture.class)
@ExtendWith(OutputCaptureExtendWithTests.BeforeAllExtension.class)
public class OutputCaptureExtendWithTests {
class OutputCaptureExtendWithTests {

@Test
void captureShouldReturnOutputCapturedBeforeTestMethod(OutputCapture output) {
assertThat(output).contains("Before all");
assertThat(output).doesNotContain("Hello");
assertThat(output).contains("Before all").doesNotContain("Hello");
}

@Test
void captureShouldReturnAllCapturedOutput(OutputCapture output) {
System.out.println("Hello World");
System.err.println("Error!!!");
assertThat(output).contains("Before all");
assertThat(output).contains("Hello World");
assertThat(output).contains("Error!!!");
assertThat(output).contains("Before all").contains("Hello World")
.contains("Error!!!");
}

static class BeforeAllExtension implements BeforeAllCallback {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
*
* @author Madhura Bhave
*/
public class OutputCaptureRegisterExtensionTests {
class OutputCaptureRegisterExtensionTests {

@RegisterExtension
OutputCapture output = new OutputCapture();
Expand All @@ -34,8 +34,7 @@ public class OutputCaptureRegisterExtensionTests {
void captureShouldReturnAllCapturedOutput() {
System.out.println("Hello World");
System.err.println("Error!!!");
assertThat(this.output).contains("Hello World");
assertThat(this.output).contains("Error!!!");
assertThat(this.output).contains("Hello World").contains("Error!!!");
}

}