Skip to content

Polish #16948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Polish #16948

wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented May 23, 2019 •
edited
Loading

This PR polishes by:

  • Adding Javadoc @since tag to OutputCapture.
  • Removing effectively unused OutputCapture.matchers.
  • Changing scopes of JUnit Jupiter test classes related to OutputCapture to package-private.
  • Chaining AssertJ assertions related to OutputCapture.
  • Removing CaptureOutputStream.write(byte[]) which is the same implementation as one from its parent.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 23, 2019
@izeye izeye force-pushed the polish-20190523 branch from f351933 to 9d3b079 Compare May 23, 2019 03:24
@snicoll snicoll self-assigned this May 25, 2019
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels May 25, 2019
@snicoll snicoll added this to the 2.2.0.M4 milestone May 25, 2019
@snicoll snicoll closed this in d8e5169 May 25, 2019
snicoll added a commit that referenced this pull request May 25, 2019
@snicoll
Merge pull request #16948 from izeye
1c14079 
* pr/16948:
  Polish
@izeye izeye deleted the polish-20190523 branch May 25, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

2.2.0.M4

Development

Successfully merging this pull request may close these issues.

3 participants

@izeye @snicoll @spring-projects-issues