Skip to content

Conversation

@marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Nov 20, 2017

  • zipkin is zipkin-legacy
  • zipkin2 is zipkin

fixes #785

@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #787 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #787      +/-   ##
============================================
- Coverage     75.97%   75.95%   -0.03%     
  Complexity     1275     1275              
============================================
  Files           179      179              
  Lines          4658     4658              
  Branches        497      497              
============================================
- Hits           3539     3538       -1     
- Misses          835      836       +1     
  Partials        284      284
Impacted Files Coverage Δ Complexity Δ
...zipkin2/sender/ZipkinKafkaSenderConfiguration.java 82.35% <ø> (ø) 4 <0> (?)
.../sleuth/zipkin/DiscoveryClientEndpointLocator.java 73.91% <ø> (ø) 6 <0> (?)
...sleuth/zipkin/ServerPropertiesEndpointLocator.java 81.39% <ø> (ø) 16 <0> (?)
.../src/main/java/sample/SampleZipkinApplication.java 66.66% <ø> (ø) 4 <0> (?)
...mework/cloud/sleuth/zipkin/ZipkinSpanListener.java 91.74% <ø> (ø) 35 <0> (?)
...d/sleuth/zipkin2/sender/ZipkinSenderCondition.java 92.85% <ø> (ø) 4 <0> (?)
...ramework/cloud/sleuth/zipkin/ZipkinProperties.java 76.08% <ø> (ø) 9 <0> (?)
...k/cloud/sleuth/zipkin2/ReporterMetricsAdapter.java 100% <ø> (ø) 9 <0> (?)
...ework/cloud/sleuth/zipkin2/ZipkinSpanReporter.java 89.13% <ø> (ø) 33 <0> (?)
...d/sleuth/zipkin/FallbackHavingEndpointLocator.java 100% <ø> (ø) 5 <0> (?)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecd77d...ca367c6. Read the comment docs.

@marcingrzejszczak marcingrzejszczak merged commit b60ff42 into master Nov 20, 2017
@marcingrzejszczak marcingrzejszczak deleted the issues_#785_zipkin_legacy branch November 20, 2017 22:06
@marcingrzejszczak marcingrzejszczak added this to the 1.3.0.RC2 milestone Nov 20, 2017
@marcingrzejszczak
Copy link
Contributor Author

We've changed the default in Sleuth so that the default zipkin starter is zipkin2. To use Zipkin1 you have to use zipkin-legacy module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming / removing Zipkin starters in Edgware / Finchley

4 participants