Skip to content

Commit b60ff42

Browse files
Made ZIpkin 2 default
fixes #785
1 parent 2ecd77d commit b60ff42

File tree

70 files changed

+90
-90
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+90
-90
lines changed

README.adoc

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ the Spring BOM
401401

402402
==== Sleuth with Zipkin via HTTP
403403

404-
If you want both Sleuth and Zipkin just add the `spring-cloud-starter-zipkin2` dependency.
404+
If you want both Sleuth and Zipkin just add the `spring-cloud-starter-zipkin` dependency.
405405

406406
[source,xml,indent=0,subs="verbatim,attributes",role="primary"]
407407
.Maven
@@ -420,12 +420,12 @@ If you want both Sleuth and Zipkin just add the `spring-cloud-starter-zipkin2` d
420420
421421
<dependency> <2>
422422
<groupId>org.springframework.cloud</groupId>
423-
<artifactId>spring-cloud-starter-zipkin2</artifactId>
423+
<artifactId>spring-cloud-starter-zipkin</artifactId>
424424
</dependency>
425425
----
426426
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
427427
the Spring BOM
428-
<2> Add the dependency to `spring-cloud-starter-zipkin2`
428+
<2> Add the dependency to `spring-cloud-starter-zipkin`
429429

430430
[source,groovy,indent=0,subs="verbatim,attributes",role="secondary"]
431431
.Gradle
@@ -437,12 +437,12 @@ dependencyManagement { <1>
437437
}
438438
439439
dependencies { <2>
440-
compile "org.springframework.cloud:spring-cloud-starter-zipkin2"
440+
compile "org.springframework.cloud:spring-cloud-starter-zipkin"
441441
}
442442
----
443443
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
444444
the Spring BOM
445-
<2> Add the dependency to `spring-cloud-starter-zipkin2`
445+
<2> Add the dependency to `spring-cloud-starter-zipkin`
446446

447447
==== Sleuth with Zipkin via RabbitMQ or Kafka
448448

@@ -451,7 +451,7 @@ dependencies. The default destination name is `zipkin`.
451451

452452
_Note: `spring-cloud-sleuth-stream` is deprecated and incompatible with these destinations_
453453

454-
If you want Sleuth over RabbitMQ add the `spring-cloud-starter-zipkin2` and `spring-rabbit`
454+
If you want Sleuth over RabbitMQ add the `spring-cloud-starter-zipkin` and `spring-rabbit`
455455
dependencies.
456456

457457
[source,xml,indent=0,subs="verbatim,attributes",role="primary"]
@@ -471,7 +471,7 @@ dependencies.
471471
472472
<dependency> <2>
473473
<groupId>org.springframework.cloud</groupId>
474-
<artifactId>spring-cloud-starter-zipkin2</artifactId>
474+
<artifactId>spring-cloud-starter-zipkin</artifactId>
475475
</dependency>
476476
<dependency> <3>
477477
<groupId>org.springframework.amqp</groupId>
@@ -480,7 +480,7 @@ dependencies.
480480
----
481481
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
482482
the Spring BOM
483-
<2> Add the dependency to `spring-cloud-starter-zipkin2` - that way all dependent dependencies will be downloaded
483+
<2> Add the dependency to `spring-cloud-starter-zipkin` - that way all dependent dependencies will be downloaded
484484
<3> To automatically configure rabbit, simply add the spring-rabbit dependency
485485

486486
[source,groovy,indent=0,subs="verbatim,attributes",role="secondary"]
@@ -493,13 +493,13 @@ dependencyManagement { <1>
493493
}
494494
495495
dependencies {
496-
compile "org.springframework.cloud:spring-cloud-starter-zipkin2" <2>
496+
compile "org.springframework.cloud:spring-cloud-starter-zipkin" <2>
497497
compile "org.springframework.amqp:spring-rabbit" <3>
498498
}
499499
----
500500
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
501501
the Spring BOM
502-
<2> Add the dependency to `spring-cloud-starter-zipkin2` - that way all dependent dependencies will be downloaded
502+
<2> Add the dependency to `spring-cloud-starter-zipkin` - that way all dependent dependencies will be downloaded
503503
<3> To automatically configure rabbit, simply add the spring-rabbit dependency
504504

505505
== Additional resources
@@ -553,7 +553,7 @@ a baggage element then it will be sent downstream either via HTTP or messaging t
553553

554554
* Provides simple metrics of accepted / dropped spans.
555555

556-
* If `spring-cloud-sleuth-zipkin2` then the app will generate and collect Zipkin-compatible traces.
556+
* If `spring-cloud-sleuth-zipkin` then the app will generate and collect Zipkin-compatible traces.
557557
By default it sends them via HTTP to a Zipkin server on localhost (port 9411).
558558
Configure the location of the service using `spring.zipkin.baseUrl`.
559559
- If you depend on `spring-rabbit` or `spring-kafka` your app will send traces to a broker instead of http.

docs/src/main/asciidoc/features.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ a baggage element then it will be sent downstream either via HTTP or messaging t
4141
4242
* Provides simple metrics of accepted / dropped spans.
4343
44-
* If `spring-cloud-sleuth-zipkin2` then the app will generate and collect Zipkin-compatible traces.
44+
* If `spring-cloud-sleuth-zipkin` then the app will generate and collect Zipkin-compatible traces.
4545
By default it sends them via HTTP to a Zipkin server on localhost (port 9411).
4646
Configure the location of the service using `spring.zipkin.baseUrl`.
4747
- If you depend on `spring-rabbit` or `spring-kafka` your app will send traces to a broker instead of http.
48-
- Note: `spring-cloud-sleuth-stream` is deprecated and should no longer be used.
48+
- Note: `spring-cloud-sleuth-stream` is deprecated and should no longer be used.
4949
5050
IMPORTANT: If using Zipkin, configure the percentage of spans exported using `spring.sleuth.sampler.percentage`
5151
(default 0.1, i.e. 10%). *Otherwise you might think that Sleuth is not working cause it's omitting some spans.*

docs/src/main/asciidoc/intro.adoc

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ the Spring BOM
280280

281281
==== Sleuth with Zipkin via HTTP
282282

283-
If you want both Sleuth and Zipkin just add the `spring-cloud-starter-zipkin2` dependency.
283+
If you want both Sleuth and Zipkin just add the `spring-cloud-starter-zipkin` dependency.
284284

285285
[source,xml,indent=0,subs="verbatim,attributes",role="primary"]
286286
.Maven
@@ -299,12 +299,12 @@ If you want both Sleuth and Zipkin just add the `spring-cloud-starter-zipkin2` d
299299
300300
<dependency> <2>
301301
<groupId>org.springframework.cloud</groupId>
302-
<artifactId>spring-cloud-starter-zipkin2</artifactId>
302+
<artifactId>spring-cloud-starter-zipkin</artifactId>
303303
</dependency>
304304
----
305305
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
306306
the Spring BOM
307-
<2> Add the dependency to `spring-cloud-starter-zipkin2`
307+
<2> Add the dependency to `spring-cloud-starter-zipkin`
308308

309309
[source,groovy,indent=0,subs="verbatim,attributes",role="secondary"]
310310
.Gradle
@@ -316,12 +316,12 @@ dependencyManagement { <1>
316316
}
317317
318318
dependencies { <2>
319-
compile "org.springframework.cloud:spring-cloud-starter-zipkin2"
319+
compile "org.springframework.cloud:spring-cloud-starter-zipkin"
320320
}
321321
----
322322
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
323323
the Spring BOM
324-
<2> Add the dependency to `spring-cloud-starter-zipkin2`
324+
<2> Add the dependency to `spring-cloud-starter-zipkin`
325325

326326
==== Sleuth with Zipkin via RabbitMQ or Kafka
327327

@@ -330,7 +330,7 @@ dependencies. The default destination name is `zipkin`.
330330

331331
_Note: `spring-cloud-sleuth-stream` is deprecated and incompatible with these destinations_
332332

333-
If you want Sleuth over RabbitMQ add the `spring-cloud-starter-zipkin2` and `spring-rabbit`
333+
If you want Sleuth over RabbitMQ add the `spring-cloud-starter-zipkin` and `spring-rabbit`
334334
dependencies.
335335

336336
[source,xml,indent=0,subs="verbatim,attributes",role="primary"]
@@ -350,7 +350,7 @@ dependencies.
350350
351351
<dependency> <2>
352352
<groupId>org.springframework.cloud</groupId>
353-
<artifactId>spring-cloud-starter-zipkin2</artifactId>
353+
<artifactId>spring-cloud-starter-zipkin</artifactId>
354354
</dependency>
355355
<dependency> <3>
356356
<groupId>org.springframework.amqp</groupId>
@@ -359,7 +359,7 @@ dependencies.
359359
----
360360
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
361361
the Spring BOM
362-
<2> Add the dependency to `spring-cloud-starter-zipkin2` - that way all dependent dependencies will be downloaded
362+
<2> Add the dependency to `spring-cloud-starter-zipkin` - that way all dependent dependencies will be downloaded
363363
<3> To automatically configure rabbit, simply add the spring-rabbit dependency
364364

365365
[source,groovy,indent=0,subs="verbatim,attributes",role="secondary"]
@@ -372,13 +372,13 @@ dependencyManagement { <1>
372372
}
373373
374374
dependencies {
375-
compile "org.springframework.cloud:spring-cloud-starter-zipkin2" <2>
375+
compile "org.springframework.cloud:spring-cloud-starter-zipkin" <2>
376376
compile "org.springframework.amqp:spring-rabbit" <3>
377377
}
378378
----
379379
<1> In order not to pick versions by yourself it's much better if you add the dependency management via
380380
the Spring BOM
381-
<2> Add the dependency to `spring-cloud-starter-zipkin2` - that way all dependent dependencies will be downloaded
381+
<2> Add the dependency to `spring-cloud-starter-zipkin` - that way all dependent dependencies will be downloaded
382382
<3> To automatically configure rabbit, simply add the spring-rabbit dependency
383383

384384
== Additional resources

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@
2828
<modules>
2929
<module>spring-cloud-sleuth-dependencies</module>
3030
<module>spring-cloud-sleuth-core</module>
31+
<module>spring-cloud-sleuth-zipkin-legacy</module>
3132
<module>spring-cloud-sleuth-zipkin</module>
32-
<module>spring-cloud-sleuth-zipkin2</module>
3333
<module>spring-cloud-sleuth-stream</module>
3434
<module>spring-cloud-sleuth-reactor</module>
3535
<module>spring-cloud-sleuth-zipkin-stream</module>
3636
<module>spring-cloud-starter-sleuth</module>
37+
<module>spring-cloud-starter-zipkin-legacy</module>
3738
<module>spring-cloud-starter-zipkin</module>
38-
<module>spring-cloud-starter-zipkin2</module>
3939
<module>spring-cloud-sleuth-samples</module>
4040
<module>docs</module>
4141
</modules>

spring-cloud-sleuth-dependencies/pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
</dependency>
3333
<dependency>
3434
<groupId>org.springframework.cloud</groupId>
35-
<artifactId>spring-cloud-sleuth-zipkin</artifactId>
35+
<artifactId>spring-cloud-sleuth-zipkin-legacy</artifactId>
3636
<version>${project.version}</version>
3737
</dependency>
3838
<dependency>
3939
<groupId>org.springframework.cloud</groupId>
40-
<artifactId>spring-cloud-sleuth-zipkin2</artifactId>
40+
<artifactId>spring-cloud-sleuth-zipkin</artifactId>
4141
<version>${project.version}</version>
4242
</dependency>
4343
<dependency>
@@ -52,12 +52,12 @@
5252
</dependency>
5353
<dependency>
5454
<groupId>org.springframework.cloud</groupId>
55-
<artifactId>spring-cloud-starter-zipkin</artifactId>
55+
<artifactId>spring-cloud-starter-zipkin-legacy</artifactId>
5656
<version>${project.version}</version>
5757
</dependency>
5858
<dependency>
5959
<groupId>org.springframework.cloud</groupId>
60-
<artifactId>spring-cloud-starter-zipkin2</artifactId>
60+
<artifactId>spring-cloud-starter-zipkin</artifactId>
6161
<version>${project.version}</version>
6262
</dependency>
6363
<dependency>

spring-cloud-sleuth-samples/README.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ There are a few samples with slightly different features. You can run all of the
66

77
* `spring-cloud-sleuth-sample`: vanilla (no zipkin) web app that calls back to itself on various endpoints ("/", "/call", "/async")
88

9-
* `spring-cloud-sleuth-sample-zipkin2`: same as vanilla sample but with zipkin (set `sample.zipkin.enabled=true` if you have a collector running)
9+
* `spring-cloud-sleuth-sample-zipkin`: same as vanilla sample but with zipkin (set `sample.zipkin.enabled=true` if you have a collector running)
1010

1111
* `spring-cloud-sleuth-sample-messaging`: a Spring Integration application with two HTTP endpoints ("/" and "/xform")
1212

@@ -16,7 +16,7 @@ The Ribbon sample makes an interesting demo or playground for learning about zip
1616

1717
=== Running samples with Zipkin
1818

19-
1. Optionally run the https://github.com/openzipkin/zipkin[Zipkin] Server, e.g. via docker compose (there's a `docker-compose.yml` in https://github.com/spring-cloud/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin2[Spring Cloud Sleuth], or in https://github.com/openzipkin/docker-zipkin[Docker Zipkin]
19+
1. Optionally run the https://github.com/openzipkin/zipkin[Zipkin] Server, e.g. via docker compose (there's a `docker-compose.yml` in https://github.com/spring-cloud/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin[Spring Cloud Sleuth], or in https://github.com/openzipkin/docker-zipkin[Docker Zipkin]
2020
7. Run the zipkin sample application (set `sample.zipkin.enabled=false` if you have no Zipkin running). If you are using a VM to run docker you might need to tunnel port 9411 to localhost, or change the `spring.zipkin.baseUrl`.
2121
8. Hit `http://localhost:3380`, `http://localhost:3380/call`, `http://localhost:3380/async` for some interesting sample traces (the app callas back to itself).
2222
9. Go to `http://localhost:9411` for Zipkin's UI (if you are using boot2docker the host will be different)

spring-cloud-sleuth-samples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<module>spring-cloud-sleuth-sample-websocket</module>
2424
<module>spring-cloud-sleuth-sample-feign</module>
2525
<module>spring-cloud-sleuth-sample-ribbon</module>
26-
<module>spring-cloud-sleuth-sample-zipkin2</module>
26+
<module>spring-cloud-sleuth-sample-zipkin</module>
2727
</modules>
2828

2929
<build>

spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-feign/pom.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!-- ~ Copyright 2013-2017 the original author or authors. ~ ~ Licensed under
3-
the Apache License, Version 2.0 (the "License"); ~ you may not use this file
4-
except in compliance with the License. ~ You may obtain a copy of the License
5-
at ~ ~ http://www.apache.org/licenses/LICENSE-2.0 ~ ~ Unless required by
6-
applicable law or agreed to in writing, software ~ distributed under the
7-
License is distributed on an "AS IS" BASIS, ~ WITHOUT WARRANTIES OR CONDITIONS
8-
OF ANY KIND, either express or implied. ~ See the License for the specific
3+
the Apache License, Version 2.0 (the "License"); ~ you may not use this file
4+
except in compliance with the License. ~ You may obtain a copy of the License
5+
at ~ ~ http://www.apache.org/licenses/LICENSE-2.0 ~ ~ Unless required by
6+
applicable law or agreed to in writing, software ~ distributed under the
7+
License is distributed on an "AS IS" BASIS, ~ WITHOUT WARRANTIES OR CONDITIONS
8+
OF ANY KIND, either express or implied. ~ See the License for the specific
99
language governing permissions and ~ limitations under the License. -->
1010

1111
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -61,14 +61,14 @@
6161
<artifactId>spring-cloud-starter-feign</artifactId>
6262
</dependency>
6363
<dependency>
64-
<!-- Including Eureka is a good test, even if there is no service to connect
64+
<!-- Including Eureka is a good test, even if there is no service to connect
6565
with because it exercises slightly different code paths in Ribbon -->
6666
<groupId>org.springframework.cloud</groupId>
6767
<artifactId>spring-cloud-starter-eureka</artifactId>
6868
</dependency>
6969
<dependency>
7070
<groupId>org.springframework.cloud</groupId>
71-
<artifactId>spring-cloud-sleuth-zipkin2</artifactId>
71+
<artifactId>spring-cloud-sleuth-zipkin</artifactId>
7272
</dependency>
7373
<dependency>
7474
<groupId>org.springframework.boot</groupId>

spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
</dependency>
8383
<dependency>
8484
<groupId>org.springframework.cloud</groupId>
85-
<artifactId>spring-cloud-sleuth-zipkin2</artifactId>
85+
<artifactId>spring-cloud-sleuth-zipkin</artifactId>
8686
</dependency>
8787
<dependency>
8888
<groupId>org.springframework.boot</groupId>

spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-ribbon/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
</dependency>
7171
<dependency>
7272
<groupId>org.springframework.cloud</groupId>
73-
<artifactId>spring-cloud-sleuth-zipkin2</artifactId>
73+
<artifactId>spring-cloud-sleuth-zipkin</artifactId>
7474
</dependency>
7575
<dependency>
7676
<groupId>org.springframework.boot</groupId>

0 commit comments

Comments
 (0)