Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Add ability to provide custom client configuration #725

Merged
merged 15 commits into from
Dec 15, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Nov 24, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

One common request is to add simple way to provide custom ClientConfiguration for different integrations. This change enables users to define a bean of name com.amazonaws.ClientConfiguration.BEAN_NAME that would be by default set on all AWS clients and in addition to that, define ClientConfiguration per client.

Client-specific beans must have specific name, for example - SQS ClientConfiguration bean must be named - sqsClientConfiguration.

💡 Motivation and Context

Common request:

💚 How did you test it?

Integration tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added component: cloudwatch CloudWatch integration related issue component: core An issue related to core functionality - credentials, region resolution component: elasticache ElastiCache integration related issue component: rds RDS integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue labels Nov 24, 2020
@eddumelendez
Copy link
Contributor

Currently, we have our own SpringCloudClientConfiguration which add a suffix to the user agent. By doing an injection of ClientConfiguration we will lose this. I think we can do something like RestTemplateBuilder and RestTemplateCustomizer and not lose this.

@maciejwalkowiak
Copy link
Contributor Author

@github-actions github-actions bot added the component: ses SES integration related issue label Dec 15, 2020
@github-actions github-actions bot added the type: documentation A documentation update label Dec 15, 2020
@maciejwalkowiak maciejwalkowiak added this to the 2.3 milestone Dec 15, 2020
@maciejwalkowiak maciejwalkowiak added type: enhancement A general enhancement and removed type: documentation A documentation update labels Dec 15, 2020
@maciejwalkowiak maciejwalkowiak merged commit 6f1edcc into 2.3.x Dec 15, 2020
@maciejwalkowiak maciejwalkowiak deleted the custom-client-configuratio branch December 15, 2020 21:23
@gauravbrills
Copy link

gauravbrills commented Jan 14, 2022

@maciejwalkowiakis is there a plan to also add this to aws-paramstore as currently there isn't a way to customize this (specially in the case w need to pass custom proxy ) . Also even marking beans as primary still uses beans from the default configuration AwsParamStoreBootstrapConfiguration we have observed for ssmClient .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: cloudwatch CloudWatch integration related issue component: core An issue related to core functionality - credentials, region resolution component: elasticache ElastiCache integration related issue component: rds RDS integration related issue component: ses SES integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: enhancement A general enhancement
Development

Successfully merging this pull request may close these issues.

3 participants