This repository was archived by the owner on Jan 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 369
Add ability to provide custom client configuration #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have our own |
eddumelendez
approved these changes
Nov 25, 2020
This was referenced Nov 30, 2020
maciejwalkowiak
added a commit
to awspring/spring-cloud-aws
that referenced
this pull request
Dec 19, 2020
@maciejwalkowiakis is there a plan to also add this to aws-paramstore as currently there isn't a way to customize this (specially in the case w need to pass custom proxy ) . Also even marking beans as primary still uses beans from the default configuration |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
component: cloudwatch
CloudWatch integration related issue
component: core
An issue related to core functionality - credentials, region resolution
component: elasticache
ElastiCache integration related issue
component: rds
RDS integration related issue
component: ses
SES integration related issue
component: sns
SNS integration related issue
component: sqs
SQS integration related issue
type: enhancement
A general enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
One common request is to add simple way to provide custom
ClientConfiguration
for different integrations. This change enables users to define a bean of namecom.amazonaws.ClientConfiguration.BEAN_NAME
that would be by default set on all AWS clients and in addition to that, defineClientConfiguration
per client.Client-specific beans must have specific name, for example - SQS
ClientConfiguration
bean must be named -sqsClientConfiguration
.💡 Motivation and Context
Common request:
💚 How did you test it?
Integration tests.
📝 Checklist
🔮 Next steps