This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Add aws-parameterstore: prefix config import #723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was added. This commit introduces the prefix `aws-parameterstore:` which will resolve the values given the configuration properties supported by parameter store integration. Also, if keys are added after the prefix then just these will be resolved. Use: `aws-parameterstore:` or `aws-secretsmanager:my-config-key` or `aws-parameterstore:my-config-key;my-anoter-config-key` Closes spring-atticgh-654
github-actions
bot
added
component: parameter-store
11 tasks
maciejwalkowiak
suggested changes
Nov 27, 2020
| } | ||
| } | ||
|
|
||
| public AwsParamStorePropertySource createPropertySource(String context, boolean optional, |
There was a problem hiding this comment.
Similar to how i suggested in SM integration, we should add logging information: 21011e6#diff-ab9058ccbead5f4685b9fc609e6e10808f622475492ea1b099af6994edfa3e70R80
...c/main/java/org/springframework/cloud/aws/paramstore/AwsParamStorePropertySourceLocator.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/cloud/aws/autoconfigure/paramstore/AwsParamStoreConfigDataLoader.java
Outdated
Show resolved
Hide resolved
...ingframework/cloud/aws/autoconfigure/paramstore/AwsParamStoreConfigDataLocationResolver.java
Outdated
Show resolved
Hide resolved
| protected AwsParamStoreProperties loadConfigProperties(Binder binder) { | ||
| AwsParamStoreProperties properties = binder | ||
| .bind(AwsParamStoreProperties.CONFIG_PREFIX, Bindable.of(AwsParamStoreProperties.class)) | ||
| .orElse(new AwsParamStoreProperties()); |
There was a problem hiding this comment.
Shouldn't orElseGet be used?
|
@eddumelendez what about the other things I mentioned? |
|
Replaced by #750 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
spring-boot2.4,Volume Mounted Config Directory Treeswasadded. This commit introduces the prefix
aws-parameterstore:whichwill resolve the values given the configuration properties supported
by parameter store integration. Also, if keys are added after the
prefix then just these will be resolved.
Use:
aws-parameterstore:oraws-parameterstore:my-config-keyoraws-parameterstore:my-config-key;my-anoter-config-keyCloses gh-654