This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Add ses module #669
Merged
Add ses module #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
force-pushed
the
ses_module
branch
2 times, most recently
from
a348693 to
9318f8c
Compare
eddumelendez
added
component: ses
eddumelendez
force-pushed
the
ses_module
branch
2 times, most recently
from
4295b0e to
900acb9
Compare
maciejwalkowiak
suggested changes
Sep 22, 2020
...ure/src/main/java/org/springframework/cloud/aws/autoconfigure/mail/SesAutoConfiguration.java
Show resolved
Hide resolved
eddumelendez
force-pushed
the
ses_module
branch
from
94969e4 to
894589e
Compare
maciejwalkowiak
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Great work @eddumelendez! When you merge it, please only write longer commit message explaining what and why are we doing here.
|
I think it would be great if we add documentation together with PRs with code changes. |
eddumelendez
force-pushed
the
ses_module
branch
from
894589e to
ce3403e
Compare
github-actions
bot
added
type: dependency-upgrade
|
@maciejwalkowiak I have rebase the branch and update the docs. Could you review it again, please? |
maciejwalkowiak
approved these changes
Nov 4, 2020
11 tasks
New modules are introduced: * spring-cloud-aws-ses * spring-cloud-starter-aws-ses Closes spring-atticgh-664
eddumelendez
force-pushed
the
ses_module
branch
from
bc71d0b to
c4683fe
Compare
|
Thanks for this, I've just had to sort out SES (in Spring Cloud AWS) and it's been a little tricky, hopefully this will make it allot easier in future for everyone. |
maciejwalkowiak
pushed a commit
to awspring/spring-cloud-aws
that referenced
this pull request
Dec 19, 2020
New modules are introduced: * spring-cloud-aws-ses * spring-cloud-starter-aws-ses References to `SimpleEmail*` have been deprecated. Closes spring-attic/spring-cloud-aws#664
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-664