Skip to content

[ENH] add tests for TiDEModel with test_tide.py #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[ENH] add tests for TiDEModel with test_tide.py #1814

wants to merge 9 commits into from

Conversation

@PranavBhatP
Copy link
Contributor

@PranavBhatP PranavBhatP commented Apr 7, 2025 •
edited
Loading

Description

This PR fixes #1807

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 87.59305% with 50 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@e87230b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ting/utils/_dependencies/tests/test_safe_import.py 0.00% 36 Missing ⚠️
pytorch_forecasting/data/data_module.py 96.25% 7 Missing ⚠️
...ch_forecasting/utils/_dependencies/_safe_import.py 68.42% 6 Missing ⚠️
...orch_forecasting/data/timeseries/_timeseries_v2.py 99.10% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage        ?   88.76%           
=======================================
  Files           ?       51           
  Lines           ?     5663           
  Branches        ?        0           
=======================================
  Hits            ?     5027           
  Misses          ?      636           
  Partials        ?        0
Flag Coverage Δ
cpu 88.76% <87.59%> (?)
pytest 88.76% <87.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly moved this to PR in progress in May - Sep 2025 mentee projects May 19, 2025
@PranavBhatP PranavBhatP marked this pull request as ready for review May 19, 2025 06:36
@fkiraly fkiraly moved this from PR in progress to PR under review in May - Sep 2025 mentee projects May 19, 2025
@phoeenniixx
Copy link
Member

phoeenniixx commented May 19, 2025

These tests are mainly for v1 right?
So these are mainly dependent on #1780 right? As _integration test will be handled by the testing framework, then will it be necessary to add the same test here as well? Are both the implementations different in some manner?

@PranavBhatP
Copy link
Contributor Author

PranavBhatP commented May 20, 2025

These tests are mainly for v1 right?

Yes, you are right. Currently the code here is independent of that PR, as I wanted to get it working with the v1 design. WIll try to make changes to align it with the PR 1780.

fnhirwa and others added 6 commits May 22, 2025 10:38
@fnhirwa @PranavBhatP
[ENH] Add Typehints to TimeSeriesDataSet to align with pep 585 (skt…
fa1dbde 
…ime#1819)

Following [pep 585](https://peps.python.org/pep-0585/)
Using standard collections for type hints.
@fnhirwa @PranavBhatP
[ENH] Allow multiple instances from multiple mock classes in `_safe_i…
7c77693 
…mport` (sktime#1818)

The issue was spotted in sktime via
sktime/sktime#8061

Updated the implementation and copied the unit tests to ensure that it
works with pytorch-forecasting.
closes sktime#1815
@phoeenniixx @PranavBhatP
[ENH] EXPERIMENTAL PR: D1 and D2 layer for v2 refactor (sktime#1811)
8fdf6de 
### Description

This PR implements the basic skeleton of D1 and D2 layer for v2.

See sktime#1736 for discussion and design.
@phoeenniixx @PranavBhatP
[BUG] EXPERIMENTAL PR: Solve the bug in data_module (sktime#1834)
3b74bb3 
This PR solves the bug in `data_module` where the
`static_categorical_features` and `static_continuous_features` were not
correctly calculated in `__getitem__` of nested class
@cngmid @PranavBhatP
[BUG] fix incorrect concatenation dimension in concat_sequences (sk…
2c6912f 
…time#1827)

### Description

This PR fixes
[1823](sktime#1823)
@phoeenniixx @PranavBhatP
[ENH] EXPERIMENTAL PR: make the data_module dataclass-like (sktime#…
b459eff 
…1832)

This PR makes the `data_modulel` dataclass-like
See discussion in sktime#1829
@github-project-automation github-project-automation bot moved this from PR under review to Done in May - Sep 2025 mentee projects May 22, 2025
@github-project-automation github-project-automation bot moved this from PR in progress to Done in Dec 2024 - Mar 2025 mentee projects May 22, 2025
@PranavBhatP
Copy link
Contributor Author

PranavBhatP commented May 22, 2025

This PR seems to have gotten messy, closing this for now and opening a better version.

@PranavBhatP PranavBhatP mentioned this pull request May 22, 2025
Merged
4 tasks
fkiraly pushed a commit that referenced this pull request May 29, 2025
@PranavBhatP
[ENH] tests for TiDE Model. (#1843)
756f61a 
### Description

This PR fixes #1807 and stacks upon PR #1780. Builds upon the PR #1814
(closed due to complex commit history).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@fkiraly fkiraly Awaiting requested review from fkiraly fkiraly is a code owner

@fnhirwa fnhirwa Awaiting requested review from fnhirwa fnhirwa is a code owner

@jdb78 jdb78 Awaiting requested review from jdb78 jdb78 is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees

@PranavBhatP PranavBhatP

Labels

None yet

Projects

Dec 2024 - Mar 2025 mentee projects
Status: Done
May - Sep 2025 mentee projects
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENH] add tests for TiDE in pytorch-forecasting

4 participants

@PranavBhatP @phoeenniixx @fnhirwa @cngmid