[ENH] Add Typehints to TimeSeriesDataSet to align with pep 585
#1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnhirwa
requested review from
benHeid,
fkiraly,
jdb78 and
yarnabrina
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
=======================================
Coverage ? 86.77%
=======================================
Files ? 46
Lines ? 5307
Branches ? 0
=======================================
Hits ? 4605
Misses ? 702
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PranavBhatP
pushed a commit
to PranavBhatP/pytorch-forecasting
that referenced
this pull request
May 22, 2025
…ime#1819) Following [pep 585](https://peps.python.org/pep-0585/) Using standard collections for type hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was introduced in pep 585 we can use standard collections as type hints.
part of #1817