Libquic integration #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINK_LIBRARIES apparently isn't set for pure interface libraries, so we weren't picking up some needed libraries found via interface targets when building a bundled static lib; this fixes it by following INTERFACE_LINK_LIBRARIES when we recurse into an interface library.
oxen-logging already requires this, and libquic and other deps are also likely moving to c++20 in the near future.
The onionreq code requires nettle (for AES encryption). If we are doing a static deps build we'll already have it (via libquic deps), but otherwise we need to find and link to it.
# Conflicts: # .gitignore
…ate' into libquic # Conflicts: # include/session/config/base.hpp # tests/test_config_userprofile.cpp
• Fixed the incorrect base32 charset • Fixed an issue where `random_base32` would needlessly copy and shuffle the base32 charset on every use
# Conflicts: # utils/ios.sh
This was referenced Feb 21, 2025
KeeJef
approved these changes
Feb 23, 2025
mpretty-cyro
pushed a commit
to mpretty-cyro/libsession-util
that referenced
this pull request
Dec 4, 2025
…tures fix: add get_pro_features body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.