Fix texture upload size and track it #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, nice find! 👍 @bors-servo r+ |
|
📌 Commit b48e32c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 3, 2018
Fix texture upload size and track it Fixes #2930 Also, apparently, we were uploading way more data then we needed. Say, if the client (Gecko) stores texture data in a 1GB memory buffer, and it wants to upload the left-top texel only, we'd fill up the PBO with all of that 1GB... But the good news is - this should be fixed with this PR. ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f3185784677b34223ed2cce9cd2358f0c93209 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2950) <!-- Reviewable:end -->
gw3583
approved these changes
Aug 3, 2018
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2930
Also, apparently, we were uploading way more data then we needed. Say, if the client (Gecko) stores texture data in a 1GB memory buffer, and it wants to upload the left-top texel only, we'd fill up the PBO with all of that 1GB... But the good news is - this should be fixed with this PR.
TODO:gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f3185784677b34223ed2cce9cd2358f0c93209This change is