Skip to content

Add namespace to secret creation heredoc #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add namespace to secret creation heredoc #492

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2036667
Add namespace to secret creation heredoc
adamrtalbot Feb 27, 2025
431cba5
Merge branch 'master' into fix_namespace_in_kubernetes_token_creator
justinegeffen Mar 4, 2025
122fda1
Merge branch 'master' into fix_namespace_in_kubernetes_token_creator
justinegeffen Mar 16, 2025
707b0f4
Rename k8s.mdx to k8s.md
justinegeffen Jun 3, 2025
3cde9df
Merge branch 'master' into fix_namespace_in_kubernetes_token_creator
justinegeffen Jun 3, 2025
8d8c88a
Update platform_versioned_docs/version-24.1/compute-envs/k8s.md
justinegeffen Jun 3, 2025
7ffca8f
Update platform_versioned_docs/version-24.1/compute-envs/k8s.md
justinegeffen Jun 3, 2025
5340bdd
Merge branch 'master' into fix_namespace_in_kubernetes_token_creator
justinegeffen Oct 7, 2025
be6cb63
Update platform_versioned_docs/version-24.1/compute-envs/k8s.md
justinegeffen Oct 7, 2025
1512cb2
Update platform_versioned_docs/version-24.1/compute-envs/k8s.md
justinegeffen Oct 7, 2025
45b247d
Merge branch 'master' into fix_namespace_in_kubernetes_token_creator
justinegeffen Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions platform_versioned_docs/version-24.1/compute-envs/k8s.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ This guide applies a Kubernetes manifest that creates a service account named `t
kind: Secret
metadata:
name: tower-launcher-token
namespace: tower-nf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next paragraph down also could do with adding the namespace explicitly to the kuebctl command to verify that token was created successfully.

kubectl -n tower-nf describe secrets/tower-launcher-token

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also slightly further down - also mossing a ns

kubectl describe secret <SERVICE-ACCOUNT-TOKEN-NAME> | grep -E '^token' | cut -f2 -d':' | tr -d '\t '

annotations:
kubernetes.io/service-account.name: tower-launcher-sa
type: kubernetes.io/service-account-token
Expand Down