-
Notifications
You must be signed in to change notification settings - Fork 5
Add namespace to secret creation heredoc #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
IMO adding an explicit namespace is always a good idea. If you don't do that, it will either end up in the IIRC I had this discussion with docs awhile ago on another ticket and there was a deliberate decision to not include it (I dont recall the reason). I'll see if I can dig up the link. Edit: Here's the link: #133 |
When I followed the instructions, I did exactly this and it took me a hot minute to work it out. |
gwright99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my comment in the Conversation tab, this issue has been covered before and the resulting structure was a deliberate decision. Sticking to the sidelines and making no comment re: viability of this PR (despite my personal opinions).
|
Taking @gwright99's comments into account it would probably make sense to update this doc to better reflect the changes we made to the enterprise content last year. @adamrtalbot, would that work? The change is here: https://github.com/seqeralabs/docs/pull/133/files. |
| kind: Secret | ||
| metadata: | ||
| name: tower-launcher-token | ||
| namespace: tower-nf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next paragraph down also could do with adding the namespace explicitly to the kuebctl command to verify that token was created successfully.
kubectl -n tower-nf describe secrets/tower-launcher-tokenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also slightly further down - also mossing a ns
kubectl describe secret <SERVICE-ACCOUNT-TOKEN-NAME> | grep -E '^token' | cut -f2 -d':' | tr -d '\t 'Signed-off-by: Justine Geffen <[email protected]>
|
Thanks for this, @adamrtalbot! I've implemented the suggested changes. Please could you give them a review and then I think we're good to merge. :) |
Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
Signed-off-by: Justine Geffen <[email protected]>
|
@adamrtalbot, I'm cleaning up our PR queue. Is this ready to merge? :) |
The heredoc for creating a k8s token was missing a namespace, or at least it didn't match the rest of the docs that focus on the tower-nf namespace. This PR adds it so that it matches up.