-
Notifications
You must be signed in to change notification settings - Fork 394
feat(): Add additional styles of ordered lists #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sanscontext please, check out if this is enough for you :) |
|
Ack, sorry had missed this in the return-from-break craziness. This looks good to me. Can you add it to the styleguide so we don't forget it's there? :) |
Oh, good point. It should be there :) we'll take care of that today 🤞 Actually, we've got a problem with this "small" issue. So yeah, we're almost there 😅 |
|
@noeemi not urgent, I was able to work around it actually, and it might be helpful to see how? |
|
@sanscontext yup that's good, but we wanted to give you the ability to create markdown lists with those style types too. That's why there are new classes created by Bart and you can use them wherever you want to. So for example: <ol class="lower-alpha">
<li>lorem</li>
<li>ipsum</li>
</ol>and: {:.lower-alpha}
- lorem
- ipsum`gives you the same result. I've just pushed some small changes to the style guide in this PR. Also, I noticed something on the subpage you mentioned: or: etc? 🤔 |
|
You're correct, it's supposed to reset the sequence on each new OL. 🤦♀ So it should re-start as 5a, 5b, etc |
|
Ah, I think we also needed the upper-case versions of this! |
|
Not sure if this is helpful, but seems related? https://stackoverflow.com/questions/54438188/how-to-reset-ordered-list-numbering-in-css |
|
take a look at the styleguide, please @sanscontext. There are 4 style types for lists right now. You just need to use different classes: And this: should give you: Additionally, you can use numbered and nested numbered lists like this one: or even select the start number: ☝️ the last one was for creating fancy lists you mentioned here #465 (comment) but unfortunately, we can't use them now and that's because of this issue #502. We can create something like this: and to get "2.1", "2.2" etc we should simply use two indentations but this again, gives us code block 🙈 |
|
I know it's a lot of content up there 🙈 Let me know about any concerns. |
sanscontext
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This reverts commit b313263.






Now you can use classes:
lower-romanandlower-alphain markdown file:`{:.lower-roman}
Closes: #465