Skip to content

Conversation

@bart-krakowski
Copy link
Contributor

Now you can use classes: lower-roman and lower-alpha in markdown file:

`{:.lower-roman}

  • lorem
  • ipsum`

Closes: #465

@bart-krakowski bart-krakowski self-assigned this Dec 23, 2019
@imklau
Copy link
Contributor

imklau commented Jan 3, 2020

@sanscontext please, check out if this is enough for you :)

@imklau imklau requested a review from sanscontext January 13, 2020 09:20
@sanscontext
Copy link
Contributor

Ack, sorry had missed this in the return-from-break craziness. This looks good to me. Can you add it to the styleguide so we don't forget it's there? :)

@imklau
Copy link
Contributor

imklau commented Jan 14, 2020

Ack, sorry had missed this in the return-from-break craziness. This looks good to me. Can you add it to the styleguide so we don't forget it's there? :)

Oh, good point. It should be there :) we'll take care of that today 🤞


Actually, we've got a problem with this "small" issue.
Markdown doesn't support nested numbered lists and we need more time for that.

Best I could do today:
Zrzut ekranu 2020-01-14 o 13 39 51

So yeah, we're almost there 😅
I hope that's not something urgent, because we're working on Segment Blog as well.
I will get back to this one in the next few days (hopefully tomorrow).

@sanscontext
Copy link
Contributor

@noeemi not urgent, I was able to work around it actually, and it might be helpful to see how?
https://github.com/segmentio/segment-docs/blob/master/src/legal/data-protection-addendum.html#L6

@imklau
Copy link
Contributor

imklau commented Jan 14, 2020

@sanscontext yup that's good, but we wanted to give you the ability to create markdown lists with those style types too. That's why there are new classes created by Bart and you can use them wherever you want to.

So for example:

<ol class="lower-alpha">
  <li>lorem</li>
  <li>ipsum</li>
</ol>

and:

{:.lower-alpha}
-  lorem
-  ipsum`

gives you the same result.

I've just pushed some small changes to the style guide in this PR.
These 'lower-alpha' and 'lower-roman' classes weren't that big challenge for us, but as I said before - nested numbers still are :)

Also, I noticed something on the subpage you mentioned:
Zrzut ekranu 2020-01-14 o 21 39 48
Is it supposed to look like this?

5. 
    p. Segment will Process Customer Data...
    q. For clarity, nothing in this Addendum limits Segment...

or:

5.
    a. Segment will Process Customer Data...
    b. For clarity, nothing in this Addendum limits Segment...

etc? 🤔

@sanscontext
Copy link
Contributor

You're correct, it's supposed to reset the sequence on each new OL. 🤦‍♀ So it should re-start as 5a, 5b, etc

@sanscontext
Copy link
Contributor

Ah, I think we also needed the upper-case versions of this!

@sanscontext
Copy link
Contributor

Not sure if this is helpful, but seems related? https://stackoverflow.com/questions/54438188/how-to-reset-ordered-list-numbering-in-css

@imklau
Copy link
Contributor

imklau commented Jan 15, 2020

take a look at the styleguide, please @sanscontext.

There are 4 style types for lists right now. You just need to use different classes:
{:.lower-roman}
{:.upper-roman}
{:.lower-alpha}
{:.upper-alpha}

And this:

### 2.  Definitions

For purposes of this Addendum, the terms below have the meanings set
forth below. Capitalized terms that are used but not defined in this
Addendum have the meanings given in the Agreement.

{:.lower-alpha}
1. "**Affiliate**" means any entity that directly or indirectly controls, is controlled by or is under common control with the subject entity, where "control" refers to the power to direct or cause the direction of the subject entity, whether through ownership of voting securities, by contract or otherwise.
2. "**CCPA**" means the California Consumer Privacy Act of 2018, as amended from time to time.
3. "**Customer Personal Data**" means any Customer Data (as defined in theAgreement) that is Personal Data. For purposes of this Addendum, Customer Personal Data does not include personal information of employees or other representatives of Customer with whom Segment has a direct business relationship.
4. "**Data Protection Laws**" means, with respect to a party, all privacy,data protection and information security-related laws and regulations applicable to such party's Processing of Personal Data, including, where applicable, EU Data Protection Law and the CCPA.

### 3. General Termination

{:.lower-alpha}
1. This Addendum forms part of the Agreement and except as expressly set forth in this Addendum, the Agreement remains unchanged and in full force and effect. If there is any conflict between this Addendum and the Agreement, this Addendum shall govern.
2. Any liabilities arising under this Addendum are subject to the limitations of liability in the Agreement.
3. This Addendum will be governed by and construed in accordance with governing law and jurisdiction provisions in the Agreement, unless required otherwise by applicable Data Protection Laws.
4. This Addendum will automatically terminate upon expiration or termination of the Agreement.

should give you:
Zrzut ekranu 2020-01-15 o 17 52 45
so I fixed the problem with resetting numbers on each new list 🎉 .


Additionally, you can use numbered and nested numbered lists like this one:
Zrzut ekranu 2020-01-15 o 17 54 58

or even select the start number:

{: start="6"}
1. lorem
    2. ipsum
    3. ipsum

Zrzut ekranu 2020-01-15 o 17 55 58

☝️ the last one was for creating fancy lists you mentioned here #465 (comment)

but unfortunately, we can't use them now and that's because of this issue #502.

We can create something like this:

### 2.  Definitions
{: start="2"}
1. "**Affiliate**" means any entity that directly or indirectly controls, is controlled by or is under common control with the subject entity, where "control" refers to the power to direct or cause the direction of the subject entity, whether through ownership of voting securities, by contract or otherwise.
2. "**CCPA**" means the California Consumer Privacy Act of 2018, as amended from time to time.
3. "**Customer Personal Data**" means any Customer Data (as defined in theAgreement) that is Personal Data. For purposes of this Addendum, Customer Personal Data does not include personal information of employees or other representatives of Customer with whom Segment has a direct business relationship.
4. "**Data Protection Laws**" means, with respect to a party, all privacy,data protection and information security-related laws and regulations applicable to such party's Processing of Personal Data, including, where applicable, EU Data Protection Law and the CCPA.

which gives us:
Zrzut ekranu 2020-01-15 o 18 05 07

and to get "2.1", "2.2" etc we should simply use two indentations but this again, gives us code block 🙈

@imklau
Copy link
Contributor

imklau commented Jan 15, 2020

I know it's a lot of content up there 🙈
I hope you'll understand what I meant 😅

Let me know about any concerns.

@sanscontext
Copy link
Contributor

This is amazing! Thanks so much @noeemi ! Agreed about #502 - it's a real pain in the 🍑 and I'm trying to scare up resources to help solve it.

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sanscontext sanscontext merged commit b313263 into master Jan 16, 2020
@sanscontext sanscontext deleted the 465-ordered-lists branch January 16, 2020 20:11
sanscontext added a commit that referenced this pull request Jan 21, 2020
@sanscontext sanscontext restored the 465-ordered-lists branch January 21, 2020 22:55
sanscontext added a commit that referenced this pull request Jan 21, 2020
@sanscontext sanscontext deleted the 465-ordered-lists branch February 6, 2020 23:58
bot-docsteam added a commit that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow other types of ordered list styles

5 participants