Check for last instance of .js extension in filename #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, looks like this will fix #703 |
arielsilvestri
force-pushed
the
LIBWEB-1278
branch
from
c586c54 to
f8846e9
Compare
silesky
reviewed
Dec 6, 2022
| const clientName = file.substring(0, file.indexOf('.')); | ||
| const clientName = file.includes('analytics.js-') ? | ||
| file.substring(0, file.lastIndexOf('.js')) : | ||
| file.substring(0, file.indexOf('.')); |
There was a problem hiding this comment.
Can we simplify to this?
const clientName = file.substring(0, file.lastIndexOf('.js'))There was a problem hiding this comment.
That would affect the way our .dynamic.js.gz files are obfuscated and uploaded, which would require a change in how we fetch those files in ajs. It's doable, just would require a bit of a larger change to support and would still have some extra logic, just elsewhere.
There was a problem hiding this comment.
ah K... I didn't realize that was a case we had to handle.
Maybe we should we add a comment in the code about what the expected filename formats are?
There was a problem hiding this comment.
Done @silesky !
There was a problem hiding this comment.
Thanks @arielsilvestri -- I suggested a tweak to the comment (doctests like they have in elixir would be great here =))
arielsilvestri
force-pushed
the
LIBWEB-1278
branch
from
46adafd to
4a3cc75
Compare
silesky
reviewed
Dec 8, 2022
Co-authored-by: Seth Silesky <[email protected]>
silesky
approved these changes
Dec 8, 2022
sinhaayush7
pushed a commit
to CleverTap/analytics.js-integrations
that referenced
this pull request
Jan 3, 2023
* Check for last instance of .js extension in filename * adding clarifying comments for change * Update scripts/upload-assets.js Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: Seth Silesky <[email protected]>
pooyaj
pushed a commit
that referenced
this pull request
Jan 10, 2023
* updates clevertap sdks path * updates clevertap sdk url * updates clevertap version in history.md and package.json * updates clevertap sdks path * updates clevertap sdk url * updates clevertap version in history.md and package.json * Check for last instance of .js extension in filename (#709) * Check for last instance of .js extension in filename * adding clarifying comments for change * Update scripts/upload-assets.js Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: Seth Silesky <[email protected]> * Add WalkMe SRI (cloned) (#718) * Add WalkMe SRI Fix previous test and add new cases * Fix unit test Co-authored-by: Francisco Garcia <[email protected]> * version bump (#719) * updates tag from http to https * removes use-https library; loads clevertap over https only * modifies segment identify to use onUserLogin instead of profile.push Co-authored-by: Ariel Silvestri <[email protected]> Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: dsjackins <[email protected]> Co-authored-by: Francisco Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
.jsin the filename of a given integration, per https://segment.atlassian.net/browse/LIBWEB-1278Testing
To prevent having to change the structure of a number of filenames/potentially breaking existing functionality, I scoped this change to account for a middleware that's prefix'ed with
analytics.jsin its filename.