Bug/sdk 2455/fix sdk for turkish servers #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-Ag
approved these changes
Dec 14, 2022
* Check for last instance of .js extension in filename * adding clarifying comments for change * Update scripts/upload-assets.js Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: Seth Silesky <[email protected]>
* Add WalkMe SRI Fix previous test and add new cases * Fix unit test Co-authored-by: Francisco Garcia <[email protected]>
pooyaj
requested changes
Jan 5, 2023
| @@ -17,11 +17,8 @@ var CleverTap = (module.exports = integration('CleverTap') | |||
| .global('clevertap') | |||
| .option('clevertap_account_id', '') | |||
| .option('region', '') | |||
| .tag('http', '<script src="http://static.clevertap.com/js/a.js">') | |||
| .tag( | |||
There was a problem hiding this comment.
There is a logic further down the code (in initialize method) that does this:
var protocol = useHttps() ? 'https' : 'http';
this.load(protocol, this.ready);
the this.load method uses protocol to decide which script to load, but with this change we removed the https script, and therefore, the this.load will fail for https cases.
There was a problem hiding this comment.
hi @pooyaj , If i understood this right, then the this.load will fail for http, since in the tag I've changed it to https now. The intent is to load the script over https only, since most of the people use https.
Also I think use-https library no longer serves the purpose, so would be removing this due to above stated reasons.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Are there breaking changes in this PR?
Testing
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources