Core typing: sendrecv.py #3059
Merged
Core typing: sendrecv.py #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpotter2
force-pushed
the
mypy-sendrecv
branch
3 times, most recently
from
fb970b3 to
b6c19ac
Compare
gpotter2
force-pushed
the
mypy-sendrecv
branch
10 times, most recently
from
6e04815 to
b645b93
Compare
Codecov Report
@@ Coverage Diff @@
## master #3059 +/- ##
==========================================
- Coverage 85.36% 85.35% -0.01%
==========================================
Files 256 256
Lines 54191 54226 +35
==========================================
+ Hits 46258 46283 +25
- Misses 7933 7943 +10
|
gpotter2
commented
Jan 29, 2021
There was a problem hiding this comment.
This is ready for review. Among other things, this PR discovered:
- fix "Bad number of arguments" type of issues on
PcapReader& cie. - type overloading of some utils: remove several cast
- fix *args being misplaced (x2)
- add some doc for sendrecv functions
- fix
select_funcbeing called with inconsistent types (dict or lists) - fix an edge case in
AsyncSnifferwhich could result inself.thread.start()being called withself.thread = None - remove unused variables in some
sendrecvfunctions - remove compat.py from sphinx generation: see the commit for an explanation. Basically there's a builtin docstring in the
typingmodule that is wrong, and that we can't fix.
This however still requires #3055 to be merged first
Comment on lines
+166
to
+169
| @overload | ||
| def get_temp_file(keep, autoext, fd): | ||
| # type: (bool, str, Literal[True]) -> IO[bytes] | ||
| pass |
Sphinx raises a warning on `typing.overload` that we cannot fix, because it's related to a dependency that is builtin :/
gpotter2
force-pushed
the
mypy-sendrecv
branch
4 times, most recently
from
b645b93 to
a1066ea
Compare
polybassa
reviewed
Feb 1, 2021
This was referenced Feb 10, 2021
Merged
|
@guedou Your call |
guedou
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
sendrecv.pyNeeds: #3055This is one of the last extremly big & annoying PRs of this kind. There are several parts left but none this central.