Skip to content

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jan 14, 2021

This PR contains optimizations to sniff's offline regarding:

  • iterables with filters (we now do not write them down to a temporary file just to read them again) but instead directly write them to tcpdump
  • detection of packet lists (we now do not iterate through the whole packet list to check that it is indeed a packet list)

It introduces in this regard the IterSocket util which acts like a SuperSocket over an iterator.

fixes #3053

@gpotter2 gpotter2 added cleanup Performs some code clean-up enhancement labels Jan 14, 2021
@gpotter2 gpotter2 force-pushed the sndrcv-opti branch 2 times, most recently from fb110a9 to 0af1ca5 Compare January 14, 2021 15:48
@gpotter2 gpotter2 force-pushed the sndrcv-opti branch 2 times, most recently from 63ac3af to af1bdc5 Compare January 16, 2021 00:16
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #3055 (73055ea) into master (ef4937f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
- Coverage   85.36%   85.34%   -0.02%     
==========================================
  Files         256      256              
  Lines       54135    54178      +43     
==========================================
+ Hits        46210    46240      +30     
- Misses       7925     7938      +13     
Impacted Files Coverage Δ
scapy/sendrecv.py 84.55% <100.00%> (+0.08%) ⬆️
scapy/supersocket.py 60.18% <100.00%> (+4.36%) ⬆️
scapy/utils.py 78.10% <100.00%> (-0.61%) ⬇️
scapy/contrib/loraphy2wan.py 97.32% <0.00%> (-1.28%) ⬇️
scapy/arch/windows/__init__.py 67.73% <0.00%> (-0.57%) ⬇️
scapy/config.py 81.29% <0.00%> (-0.20%) ⬇️
scapy/contrib/bgp.py 91.69% <0.00%> (-0.17%) ⬇️
scapy/fields.py 91.20% <0.00%> (ø)
scapy/layers/tls/automaton_cli.py 70.96% <0.00%> (+0.13%) ⬆️

@gpotter2
Copy link
Member Author

This is ready for review. Should be pretty straightforward
@guedou @p-l-

@p-l- p-l- merged commit 22cd038 into secdev:master Jan 30, 2021
@gpotter2 gpotter2 deleted the sndrcv-opti branch January 30, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Performs some code clean-up enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants