Skip to content

Conversation

gpotter2
Copy link
Member

fixes #1793

@gpotter2 gpotter2 added the bug label Jan 16, 2019
@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #1794 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
- Coverage   85.59%   85.58%   -0.01%     
==========================================
  Files         181      181              
  Lines       42216    42216              
==========================================
- Hits        36135    36131       -4     
- Misses       6081     6085       +4
Impacted Files Coverage Δ
scapy/config.py 84.58% <100%> (ø) ⬆️
scapy/layers/tls/keyexchange.py 83.26% <0%> (-1.31%) ⬇️
scapy/automaton.py 81.84% <0%> (-0.56%) ⬇️
scapy/layers/inet6.py 88.11% <0%> (-0.12%) ⬇️
scapy/sendrecv.py 82.95% <0%> (+0.17%) ⬆️
scapy/fields.py 91.76% <0%> (+0.36%) ⬆️
scapy/layers/ntp.py 92.04% <0%> (+0.53%) ⬆️

@guedou
Copy link
Member

guedou commented Jan 17, 2019

I tested it on FreeBSD12 and it works fine, except for one test in test/pipetool.uts.

@guedou guedou merged commit e5a9b82 into secdev:master Jan 17, 2019
@guedou
Copy link
Member

guedou commented Jan 17, 2019

I will submit a PR.

@gpotter2 gpotter2 deleted the bsdfix branch January 17, 2019 14:30
@gpotter2
Copy link
Member Author

Yes the last on fails on HTTP 1.1 rather than HTTP 1.0
Had the same issue when trying out #1660 but I don’t think that’s the root the issue. Otherwise the tests passed :/

@guedou
Copy link
Member

guedou commented Jan 17, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scapy all import fails on FreeBSD

2 participants