feat: limit pool tx size #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
CodSpeed Performance ReportMerging #317 will not alter performanceComparing Summary
|
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Thegaram
approved these changes
Aug 11, 2025
| .with_local_transactions_config( | ||
| pool_config_overrides.clone().apply(ctx.pool_config()).local_transactions_config, | ||
| ) | ||
| .with_max_tx_input_bytes(ctx.chain_spec().chain_config().max_tx_payload_bytes_per_block) |
There was a problem hiding this comment.
Just a few notes:
- Here we only check
tx.input, but the overall transaction could be much larger (e.g. by including a long authorization list). - Also, if
tx.input == max_payload_size, then we'll admin it into the txpool, but we must not include it in the block (the full serialized block must respect the same limit).
That said, this is not very critical, and the current impl seems idential to l2geth. The critical part is ensuring these limits during block building.
Author
There was a problem hiding this comment.
Was not aware of the second point, can always add this to the block builder, it's not much. For the first point, I think we check tx.rlp_encoding_length so this should cover the authorization list.
There was a problem hiding this comment.
This check is here: https://github.com/scroll-tech/go-ethereum/blob/develop/miner/scroll_worker.go#L836. Yes we should add it to the block builder.
frisitano
pushed a commit
that referenced
this pull request
Aug 18, 2025
* feat: limit rollup fee in tx pool Signed-off-by: Gregory Edison <[email protected]> * fix: check rollup fee Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool tx size (#317) * feat: add maxTxPayloadBytesPerBlock to ScrollChainConfig Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool max tx input bytes Signed-off-by: Gregory Edison <[email protected]> * test: set max_tx_payload_bytes_per_block Signed-off-by: Gregory Edison <[email protected]> * feat: make MockEthProvider more generic Signed-off-by: Gregory Edison <[email protected]> * test: add pool limit tests Signed-off-by: Gregory Edison <[email protected]> * fix: lints Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> * test: update Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]>
frisitano
added a commit
that referenced
this pull request
Aug 18, 2025
* feat: limit rollup fee in tx pool Signed-off-by: Gregory Edison <[email protected]> * fix: check rollup fee Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool tx size (#317) * feat: add maxTxPayloadBytesPerBlock to ScrollChainConfig Signed-off-by: Gregory Edison <[email protected]> * feat: limit pool max tx input bytes Signed-off-by: Gregory Edison <[email protected]> * test: set max_tx_payload_bytes_per_block Signed-off-by: Gregory Edison <[email protected]> * feat: make MockEthProvider more generic Signed-off-by: Gregory Edison <[email protected]> * test: add pool limit tests Signed-off-by: Gregory Edison <[email protected]> * fix: lints Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> * test: update Signed-off-by: Gregory Edison <[email protected]> * feat: disallow L1 messages in tx pool Signed-off-by: Gregory Edison <[email protected]> * test: disallow L1 messages in tx pool Signed-off-by: Gregory Edison <[email protected]> --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: frisitano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #310