fix(CodecV7): fix issues with CodecV7

[jonastheis]

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
• ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
• docs: Documentation-only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• test: Adding missing tests or correcting existing tests

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in data batch operations by detecting when required data elements are missing and providing a clear, consistent error message. This update ensures that users receive better feedback during processing, aligning error responses with similar operations for a more robust experience.
• Dependencies
  • Updated the version of the github.com/scroll-tech/go-ethereum dependency to a newer commit, ensuring access to the latest improvements and fixes in the package.

[coderabbitai]

Walkthrough

The changes modify the estimateL1CommitBatchSizeAndBlobSize method in the DACodecV7 struct by adding an error handling check. The method now verifies that the batch.Blocks slice is not empty. If it is empty, the function returns an error message stating "batch must contain at least one block" along with two zero uint64 values. This update brings the method in line with similar validations found in NewDABatch and NewDAChunk, adjusting the control flow to properly handle cases with an empty block list.

Changes

File Path	Change Summary
encoding/codecv7.go	Added an error check in estimateL1CommitBatchSizeAndBlobSize to ensure batch.Blocks is not empty. Returns (0, 0, error) when empty.
go.mod	Updated version of github.com/scroll-tech/go-ethereum dependency from v1.10.14-0.20250225152658-bcfdb48dd939 to v1.10.14-0.20250305151038-478940e79601.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant CodecV7

    Caller->>CodecV7: estimateL1CommitBatchSizeAndBlobSize(batch)
    CodecV7->>CodecV7: Check if batch.Blocks is empty
    alt batch.Blocks is empty
        CodecV7-->>Caller: Return (0, 0, error "batch must contain at least one block")
    else batch.Blocks present
        CodecV7-->>Caller: Compute and return (uint64, uint64, nil)
    end

Loading

Possibly related PRs

• feat(CodecV7): add CodecV7 to support upgrade 5.2 Euclid phase2 #33: The changes in the main PR are related to the modifications in the estimateL1CommitBatchSizeAndBlobSize method of the DACodecV7 struct, which aligns with the overall enhancements made to the DACodecV7 type in the retrieved PR, particularly regarding error handling and batch processing.
• feat(CodecV7): add CodecV7 to support upgrade 5.2 Euclid phase2 #44: The changes in the main PR, specifically the error handling in the estimateL1CommitBatchSizeAndBlobSize method of the DACodecV7 struct, are related to the modifications in the retrieved PR, which also involves the DACodecV7 type and its methods, including error handling for various operations.
• refactor(l2geth dependency): downgrade to l2geth latest develop #32: The changes in the main PR focus on error handling in the estimateL1CommitBatchSizeAndBlobSize method of the DACodecV7 struct, while the retrieved PR modifies the NewDABatch method in the DACodecV3 struct to include similar error handling for batch validation; thus, they are related at the code level through their shared focus on error handling in batch-related methods.

Suggested reviewers

• Thegaram
• colinlyguo

Poem

I'm a rabbit with a codey beat,
Hoping through functions, light on my feet.
With blocks in check and errors flagged clear,
I bounce with joy, spreading cheer.
Each line improved, a garden so neat,
Hoppy changes ensure our code is elite!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a148283 and d5088e7.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

• go.mod (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• go.mod

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: tests

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.