Skip to content

Conversation

@eduardo-rodrigues
Copy link
Member

No description provided.

@eduardo-rodrigues
Copy link
Member Author

I added a page pages/developers/qr_codes.md that so far contains an intro sentence but actually lists no QR codes. One could dynamically produce a table or list similarly to what is done for https://scikit-hep.org/documentation, but I would not know how to do it with Jekyll. Would anyone be able to help?

@henryiii
Copy link
Member

Could you please put this under packages instead? It's not a "developers" page; the Developer guidelines do not discuss the existing packages, but discuss how you develop code for Python. The "packages" pages do list out all the existing projects on various pages like documentation.

@eduardo-rodrigues
Copy link
Member Author

Could you please put this under packages instead? It's not a "developers" page; the Developer guidelines do not discuss the existing packages, but discuss how you develop code for Python. The "packages" pages do list out all the existing projects on various pages like documentation.

Sure. Have no strong feeling. I drafted under the developers directory because QR codes are useful for developers. But fair enough that is is a part of the material related to the packages.

In that respect, should I make a new page as now here or rather add a column to the table under https://scikit-hep.org/documentation? Maybe a separate page is a bit better.

@henryiii
Copy link
Member

Yes, I think a separate page is fine.

@eduardo-rodrigues
Copy link
Member Author

Yes, I think a separate page is fine.

OK, done. I will see how to list the PNG available unless you can help out with the Jekyll. Thank you.

@henryiii
Copy link
Member

I can help later this week if needed.

@eduardo-rodrigues
Copy link
Member Author

I can help later this week if needed.

Brilliant, many thanks 👍!

@eduardo-rodrigues
Copy link
Member Author

OK @henryiii, I tried a very simple way of displaying the images. I did not check building the site as it is as bit of a pain on Windows (though I should try sometime with WSL!).

@eduardo-rodrigues
Copy link
Member Author

@henryiii, are you then able to build the site locally and test that what I wrote displays just fine?

@henryiii
Copy link
Member

henryiii commented Nov 1, 2022

Was going to respond I'd have time tonight or tomorrow, but realized just building it was likely as quick as responding. :)

Screenshot 2022-11-01 at 10 55 45 AM

Screenshot 2022-11-01 at 10 56 24 AM

@eduardo-rodrigues
Copy link
Member Author

eduardo-rodrigues commented Nov 1, 2022

Seems to do the job at least. The pics are downloadable. If OK as a version 0 at least, then approve and we get this in :).

Thanks very much for the quick help!

@eduardo-rodrigues
Copy link
Member Author

Cool, let's 🚀 it!

@eduardo-rodrigues eduardo-rodrigues merged commit a8a1154 into main Nov 1, 2022
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-add-qr-codes branch November 1, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants