Split syntax and snippets #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Duhemm
reviewed
Oct 1, 2018
gabro
force-pushed
the
split-snippets-and-syntax
branch
from
73bef58 to
71fc3fd
Compare
Duhemm
approved these changes
Oct 2, 2018
|
Thank you for merging, @Duhemm! Will you take care of publishing the new plugins on the Marketplace? |
|
I took care of publishing |
|
Thank you, @nicolasstucki! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for splitting the syntax and the snippets into different packages.
The reasoning behind this is that I believe the syntax extension should as minimal as possible and only provide the grammar, while snippets should be opt-in, since they're quite annoying for the users if they trigger unexpectedly.
This is similar to what other languages do on the Marketplace.
Note that I've made the snippets plugin to depend on the syntax one, so that you can't install snippets without the syntax, which would be a cause of confusion.