Remove snippets. #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the snippets to be distracting, especially because the suggestions appear in positions where the resulting code is invalid. Snippets should belong in separate vscode packages with the category "snippets". That is how it's done for TypeScript: https://marketplace.visualstudio.com/search?term=typescript&target=VSCode&category=Snippets&sortBy=Relevance Note that a snippet plugin can be located in the same github repo as the syntax.
|
Note, a language server is able to provide smarter snippet completions based on the position of the cursor. Given that this package is expected to be shared for all Scala-related vscode plugins, I think it should do only syntax highlighting. |
|
Superseded by #3, which splits the snippets into a separate package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the snippets to be distracting, especially because the
suggestions appear in positions where the resulting code is invalid.
Snippets should belong in separate vscode packages with the category
"snippets". That is how it's done for TypeScript:
https://marketplace.visualstudio.com/search?term=typescript&target=VSCode&category=Snippets&sortBy=Relevance
Note that a snippet plugin can be located in the same github repo as the
syntax.