Skip to content

keep serialization stability on Scala 2.13.9 #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2022

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented May 13, 2022

fixes scala/scala-dev#809

tested locally with:

set Global / resolvers += "integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"
++2.13.9-bin-e623b15
junit/testOnly scala.SerializationStabilityTest

@SethTisue
Copy link
Member Author

this was failing on Scala 3.0.2. maybe it will pass on 3.1.3-RC3?

@SethTisue
Copy link
Member Author

SethTisue commented May 13, 2022

nope. @lrytz perhaps you'd like to dig into this? else one or both of us can return to it after Dublin

it isn't clear to me offhand if this is a real problem or whether we just need to make the test use different expected results on different Scala versions?

@lrytz
Copy link
Member

lrytz commented May 13, 2022

Hmm... Scala 3 generates a slightly different classfile, which means a different generated SVUID if the file was compiled with Scala 2. What I would do is update the scala-3 version of the test (https://github.com/scala/scala-parallel-collections/blob/main/junit/src/test/scala-3/scala/SerializationStabilityTest.scala) so that it passes after this change. The risk that anyone is deserializing across different Scala 3 versions is probably 0.

@SethTisue
Copy link
Member Author

okay will do

@SethTisue SethTisue self-assigned this May 13, 2022
@SethTisue SethTisue marked this pull request as draft May 13, 2022 16:35
SethTisue added 2 commits May 18, 2022 15:42
This reverts commit 1c1a40f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recent 2.13.x broke SerializationStabilityTest in scala-parallel-collections
2 participants