Stabilise OldHashSet serialisation independent of the generated classfile #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
force-pushed
the
stabilise-OldHashSet
branch
from
5db57a5 to
2c76751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
After adjusting flags generated in classfiles for mixin methods in Scala 3, we have come across failures in our closed community-build test suite in the
SerialisationStabilityTest:To fix this, I’ve adjusted the
SerialVersionUIDof the problematicOldHashSet, and updated the scala-3 version of the test (which I had to do, as I based the serialVersionUID on the one generated for scala-2, to keep that stable).This isn’t strictly necessary (we can just adjust our fork we use in the closed community-build to make the test pass), but I saw similar changes being done in the past (#220, #223, #240) and I think this will be useful regardless.