Skip to content

unfork sbinary #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2018
Merged

unfork sbinary #678

merged 1 commit into from
Feb 7, 2018

Conversation

SethTisue
Copy link
Member

in a local test, sbinary couldn't find the cloc-plugin dependency.
no idea what that's about.

I should return to it once I clear my plate of some higher-priority
tasks.

@SethTisue SethTisue self-assigned this Feb 1, 2018
@SethTisue
Copy link
Member Author

sbinary couldn't find the cloc-plugin dependency

now it's happening over at #618 too

@SethTisue
Copy link
Member Author

oh, this is familiar. the cause is that update is being called during dependency extraction. usually Scalafmt related. in sbt-io it was sbt-houserules related.

@SethTisue
Copy link
Member Author

SethTisue commented Feb 7, 2018

perhaps relevant: lucidsoftware/neo-sbt-scalafmt@545079f (note the use of update.value)

@SethTisue SethTisue changed the title [wip] unfork sbinary unfork sbinary Feb 7, 2018
@SethTisue
Copy link
Member Author

I think this one just needs the same workaround we used for sbt-io (and elsewhere). but the sttp one seems harder

@SethTisue SethTisue merged commit 32ba42b into scala:2.12.x Feb 7, 2018
@SethTisue SethTisue deleted the unfork-sbinary branch February 7, 2018 22:29
@SethTisue
Copy link
Member Author

(green in local test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant