Skip to content

Commit 32ba42b

Browse files
authored
Merge pull request #678 from SethTisue/unfork-sbinary
unfork sbinary
2 parents f47a1e4 + 3863d03 commit 32ba42b

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

configs/community.dbuild

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -458,18 +458,17 @@ build += {
458458
]
459459
}
460460

461-
// forked (October 2017) to work around unfriendliness between dbuild
462-
// and sbt-houserules 0.3.4; details at
463-
// https://github.com/scala/community-builds/issues/603 . we should
464-
// be able to unfork now that sbt 0.13.17 is out, once a new sbt-houserules
465-
// removes the offending workaround code
466461
${vars.base} {
467462
name: "sbinary"
468463
uri: ${vars.uris.sbinary-uri}
469464
extra.options: ["-Dbintray.user=dummy", "-Dbintray.pass=dummy"]
470-
// may be needed again once we're on current sbt-houserules again
471-
// extra.commands: ${vars.default-commands} ["set every scalafmtOnCompile := false"]
472-
// check-missing: false // ignore missing scalafmt
465+
// we have to disable this early (extra.commands isn't soon enough)
466+
// or scalafmt will run `update` and `cloc-plugin` won't be found
467+
extra.settings: ${vars.base.extra.settings} [
468+
"scalafmtOnCompile in ThisBuild := false"
469+
"scalafmtOnCompile in Sbt := false"
470+
]
471+
check-missing: false // ignore missing scalafmt
473472
}
474473

475474
${vars.base} {

configs/project-refs.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ vars.uris: {
7676
play-ws-uri: "https://github.com/playframework/play-ws.git"
7777
pprint-uri: "https://github.com/lihaoyi/pprint.git"
7878
pureconfig-uri: "https://github.com/SethTisue/pureconfig.git#community-build-2.12" # was pureconfig, master
79-
sbinary-uri: "https://github.com/scalacommunitybuild/sbinary.git#community-build-2.12" # was sbt, master
79+
sbinary-uri: "https://github.com/sbt/sbinary.git"
8080
sbt-io-uri: "https://github.com/sbt/io.git#v1.1.3"
8181
sbt-librarymanagement-uri: "https://github.com/sbt/librarymanagement.git#v1.1.2"
8282
sbt-testng-uri: "https://github.com/sbt/sbt-testng.git"

0 commit comments

Comments
 (0)