-
Notifications
You must be signed in to change notification settings - Fork 59
add sttp and fs2-reactive-streams #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2077/consoleFull |
let's try again, with |
and again, after some scalafmt-related tweaking: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2079/consoleFull |
these should be easy enough to address, either by disabling the subprojects in question, or adding the libraries:
but I don't know wtf this is:
|
new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2096/consoleFull |
let's try that again with merged changes from 2.12.x head: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2099/consoleFull |
|
really not sure what that error is about. further commits haven't helped |
well, I wanted to finish this up, but there's just too much else on my plate right now. I threw it on the list at #161 and linked to this PR in case I decide to take it back up (or somebody else wants to work on it) |
says @adamw:
|
@SethTisue yes, well, since then sbt has been updated, and as I understand the build should work fine when excluding some modules but it doesn't - is it something in sttp's build which prevents this from working? |
@adamw I was confused before, I think.... there is no mysterious problem here, it's just that fs2-reactive-streams needs be in there first before we can add sttp. I'll try it sometime soon-ish and see how it goes |
new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2395/consoleFull (404 til Jenkins finishes his holiday secret-Santa party shopping) |
tons of compile errors in fs2-reactive-streams, e.g.:
|
I suggest we revisit this after cats 1.0.0 final is out and after the whole Typelevel ecosystem has pushed that through (including a final fs2 0.10 release that uses it). Wading into this stuff is currently too fragile |
ticket on the cats 1.0 upgrade: #653 |
the cats 1.0 upgrade is finished. over in our sttp fork I merged master onto my community-build-2.12 branch, and here in this repo I merged 2.12.x into this PR |
new test run queued: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2579/consoleFull (404 for now, Jenkins is busy) |
fs2-reactive-streams fails to compile. the first error is
over in the fs2 repo I see that I imagine once fs2 0.10 comes out, at some point fs2-reactive-streams will upgrade to it and we could try again. closing for now |
zainab-ali/fs2-reactive-streams#43 should enable a try-again on this |
@adamw I think you'll need to upgrade sttp to fs2 0.10 to make this error go away. currently you're on 0.10.0-M10. I think the way to fix it is to move to
|
for now I'll simply exclude your |
fyi @zainab-ali |
@SethTisue updated to latest |
@adamw where? did you push the change? |
@SethTisue there was a connection error during push, now it's pushed :) |
thanks! 7f64fdc re-adds the subproject in question |
fyi @adamw