Skip to content

add sttp and fs2-reactive-streams #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 26, 2017

fyi @adamw

@SethTisue
Copy link
Member Author

SethTisue commented Oct 26, 2017

test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2077/consoleFull (404 til Jenkins finishes brushing the dust and cobwebs off a newly discovered cache of vintage Typesafe swag)

@SethTisue SethTisue self-assigned this Oct 26, 2017
@SethTisue
Copy link
Member Author

let's try again, with sbt.version set appropriately this time: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2078/consoleFull

@SethTisue
Copy link
Member Author

and again, after some scalafmt-related tweaking: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2079/consoleFull

@SethTisue
Copy link
Member Author

these should be easy enough to address, either by disabling the subprojects in question, or adding the libraries:

  • [sttp] [warn] **** Missing dependency: the library com.github.zainab-ali#fs2-reactive-streams is not provided (in space "default") by any project in this configuration file.
  • [sttp] [warn] **** Missing dependency: the library io.circe#circe-parser is not provided (in space "default") by any project in this configuration file. are easy enough to understand

but I don't know wtf this is:

[sttp] [error] Modules were resolved with conflicting cross-version suffixes in {file:/home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.9/project-builds/sttp-e1fdb9bddff73c71fe68ffdfb5cfe4444cb2dc77/}tests:
[sttp] [error]    org.typelevel:cats-macros <none>, _2.12
[sttp] [error]    org.typelevel:cats-effect <none>, _2.12
[sttp] [error]    org.typelevel:cats-kernel <none>, _2.12
[sttp] [error]    org.typelevel:machinist <none>, _2.12
[sttp] [error]    org.typelevel:cats-core <none>, _2.12

@SethTisue
Copy link
Member Author

SethTisue commented Oct 30, 2017

new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2096/consoleFull (404 til Jenkins finishes swimming with the manatees)

@SethTisue
Copy link
Member Author

SethTisue commented Oct 31, 2017

let's try that again with merged changes from 2.12.x head: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2099/consoleFull (404 til Jenkins finishing picking a big of hunk of he doesn't even want to know what it is out of from between his teeth)

@SethTisue
Copy link
Member Author

[sttp] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[sttp] [warn] 	::          UNRESOLVED DEPENDENCIES         ::
[sttp] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[sttp] [warn] 	:: com.softwaremill.sttp#async-http-client-backend-fs2;0.0.20-dbuildx98c95f489f1d4f1bfc0c4451cee79baee72091be: not found
[sttp] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

really not sure what that error is about. further commits haven't helped

@SethTisue SethTisue mentioned this pull request Nov 20, 2017
@SethTisue
Copy link
Member Author

well, I wanted to finish this up, but there's just too much else on my plate right now. I threw it on the list at #161 and linked to this PR in case I decide to take it back up (or somebody else wants to work on it)

@SethTisue SethTisue closed this Nov 20, 2017
@SethTisue
Copy link
Member Author

SethTisue commented Dec 11, 2017

says @adamw:

I just noticed this & a (so far failed) attempt to add sttp. No idea how this works, but if you would need some help on the sttp's build, let me know :)

@adamw
Copy link

adamw commented Dec 12, 2017

@SethTisue yes, well, since then sbt has been updated, and as I understand the build should work fine when excluding some modules but it doesn't - is it something in sttp's build which prevents this from working?

@SethTisue
Copy link
Member Author

@adamw I was confused before, I think.... there is no mysterious problem here, it's just that fs2-reactive-streams needs be in there first before we can add sttp. I'll try it sometime soon-ish and see how it goes

@SethTisue SethTisue reopened this Dec 12, 2017
@SethTisue SethTisue removed the on hold label Dec 12, 2017
@SethTisue
Copy link
Member Author

SethTisue commented Dec 13, 2017

new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2395/consoleFull (404 til Jenkins finishes his holiday secret-Santa party shopping)

@SethTisue
Copy link
Member Author

tons of compile errors in fs2-reactive-streams, e.g.:

[fs2-reactive-streams] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.9/project-builds/fs2-reactive-streams-5fb9cbb5bebf7cef2afd2cf8e7e4e97f82d7964c/core/src/main/scala/fs2/interop/reactivestreams/StreamSubscriber.scala:8:8: object Promise is not a member of package fs2.async
[fs2-reactive-streams] [error] import fs2.async.{Promise, Ref}
[fs2-reactive-streams] [error]        ^

@SethTisue SethTisue removed their assignment Dec 14, 2017
@SethTisue
Copy link
Member Author

SethTisue commented Dec 14, 2017

I suggest we revisit this after cats 1.0.0 final is out and after the whole Typelevel ecosystem has pushed that through (including a final fs2 0.10 release that uses it). Wading into this stuff is currently too fragile

@SethTisue
Copy link
Member Author

ticket on the cats 1.0 upgrade: #653

@SethTisue
Copy link
Member Author

the cats 1.0 upgrade is finished. over in our sttp fork I merged master onto my community-build-2.12 branch, and here in this repo I merged 2.12.x into this PR

@SethTisue SethTisue removed the on hold label Jan 25, 2018
@SethTisue SethTisue self-assigned this Jan 25, 2018
@SethTisue
Copy link
Member Author

new test run queued: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2579/consoleFull (404 for now, Jenkins is busy)

@SethTisue
Copy link
Member Author

fs2-reactive-streams fails to compile. the first error is

[fs2-reactive-streams] [error] /Users/tisue/community.212/target-0.9.9/project-builds/fs2-reactive-streams-60051abc8aef0da66fb828297f5c53dfbbaa2c0d/core/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala:106:12: not found: type AsyncPull
[fs2-reactive-streams] [error]       aap: AsyncPull[F, Option[(Segment[A, Unit], Stream[F, A])]],
[fs2-reactive-streams] [error]            ^

over in the fs2 repo I see that AsyncPull was removed by typelevel/fs2#1066

I imagine once fs2 0.10 comes out, at some point fs2-reactive-streams will upgrade to it and we could try again. closing for now

@SethTisue SethTisue closed this Jan 25, 2018
@SethTisue SethTisue reopened this Feb 6, 2018
@SethTisue
Copy link
Member Author

zainab-ali/fs2-reactive-streams#43 should enable a try-again on this

@SethTisue SethTisue mentioned this pull request Feb 7, 2018
@SethTisue
Copy link
Member Author

@adamw I think you'll need to upgrade sttp to fs2 0.10 to make this error go away. currently you're on 0.10.0-M10. I think the way to fix it is to move to "com.github.zainab-ali" %% "fs2-reactive-streams" % "0.5.0"

[sttp] [error] /Users/tisue/community.212/target-0.9.9/project-builds/sttp-b0a17e3b67acebf6e11f3c2d33519f5590682631/tests/src/test/scala/com/softwaremill/sttp/streaming/AsyncHttpClientFs2StreamingTests.scala:27:8: value runFoldMonoid is not a member of fs2.Stream[cats.effect.IO,String]
[sttp] [error] possible cause: maybe a semicolon is missing before `value runFoldMonoid'?
[sttp] [error]       .runFoldMonoid
[sttp] [error]        ^

@SethTisue
Copy link
Member Author

for now I'll simply exclude your tests subproject from the community build, so we can get this merged

@SethTisue SethTisue changed the title add sttp add sttp and fs2-reactive-streams Feb 7, 2018
@SethTisue SethTisue merged commit 235dc86 into scala:2.12.x Feb 7, 2018
@SethTisue SethTisue deleted the add-sttp branch February 7, 2018 22:46
@SethTisue
Copy link
Member Author

fyi @zainab-ali

@adamw
Copy link

adamw commented Feb 8, 2018

@SethTisue updated to latest fs2-reactive-streams

@SethTisue
Copy link
Member Author

@adamw where? did you push the change?

@adamw
Copy link

adamw commented Feb 8, 2018

@SethTisue there was a connection error during push, now it's pushed :)

@SethTisue
Copy link
Member Author

thanks! 7f64fdc re-adds the subproject in question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants