Skip to content

push through cats 1.0 upgrade everywhere #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue Dec 17, 2017 · 6 comments · Fixed by #671
Closed

push through cats 1.0 upgrade everywhere #653

SethTisue opened this issue Dec 17, 2017 · 6 comments · Fixed by #671
Assignees
@SethTisue

Comments

@SethTisue
Copy link
Member

SethTisue commented Dec 17, 2017 •
edited
Loading

a number of breaking changes were made between 1.0.0-MF (which is about where we are currently) and 1.0.0-RC1

I don't want to attempt this too early, since I'll likely just hit projects that haven't upgraded yet, but most of those projects will upgrade of their own accord if I just wait a little longer, I don't want to get too deep into the business of submitting upgrade PRs myself. so for now I'm preferring to freeze things
This was referenced Dec 17, 2017
Closed
Merged
@SethTisue
Copy link
Member Author

SethTisue commented Jan 17, 2018 •
edited
Loading

okay, let's get the ball rolling on this: https://github.com/SethTisue/community-builds/tree/cats-1.0

@SethTisue SethTisue self-assigned this Jan 23, 2018
@SethTisue
Copy link
Member Author

SethTisue commented Jan 23, 2018 •
edited
Loading

in local testing,

[http4s] Processing subproject: core
[http4s] [error] **** Missing dependency: the library org.http4s#parboiled is not provided (in space "scala.jawn_0_11") by any project in this configuration file.

looks like http4s has their own fork of parboiled 1? parboiled 2

@SethTisue
Copy link
Member Author

SethTisue commented Jan 24, 2018 •
edited
Loading 

[info] >>> The dbuild result is------------: FAILED (failed: algebra, pureconfig, scalikejdbc)

getting close!

@SethTisue SethTisue mentioned this issue Jan 24, 2018
Closed
@SethTisue
Copy link
Member Author

the scalikejdbc failure looks probably unrelated and intermittent

algebra has a cats 1.0 upgrade PR we can probably use

pureconfig has upgraded to cats 1.0 on master, so we just need to refresh our fork

@SethTisue
Copy link
Member Author

SethTisue commented Jan 24, 2018 •
edited
Loading

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2570/consoleFull

progress: only spire now fails (and breeze and multibot depend on it)

SethTisue added a commit to SethTisue/community-build that referenced this issue Jan 24, 2018
@SethTisue
upgrade cats to 1.0
d2bdc12 
fixes scala#653

* removes (hopefully temporarily): spire, breeze, multibot
* unfreezes: cats, fs2, monix, paiges, cats-effect, jawn-fs2
* adds http4s-parboiled2 (dependency of http4s)
* temporarily uses algebra fork with cats upgrade
* pureconfig fork refreshed to include cats upgrade
@SethTisue SethTisue mentioned this issue Jan 24, 2018
Merged
@SethTisue
Copy link
Member Author

the removal of spire, breeze, and multibot now has its own ticket: #672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade cats to 1.0 SethTisue/community-build
1 participant
@SethTisue