Skip to content

Unfork circe #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Unfork circe #651

wants to merge 2 commits into from

Conversation

dwijnand
Copy link
Member

No longer need to use the fork with coursier removed (#629) or sbt-microsite upgraded (47degrees/sbt-microsites#248 + circe/circe#803).

No longer need to use the fork with coursier removed (#629) or sbt-microsite upgraded (47degrees/sbt-microsites#248 + circe/circe#803).
@SethTisue
Copy link
Member

SethTisue commented Dec 15, 2017

test run queued: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2407/consoleFull (404 til Jenkins finishes eating his plate of arugula piled so tall he can't see over it)

@dwijnand
Copy link
Member Author

ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job.

?

@SethTisue
Copy link
Member

SethTisue commented Dec 16, 2017

I didn't notice the PR was off this repo, not your fork. New test run (after merging current 2.12.x onto this branch): https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/2412/consoleFull (404 til Jenkins finishes deciding which paperback edition of Clifford D. Simak’s City has the best cover art)

@SethTisue SethTisue self-assigned this Dec 16, 2017
@dwijnand
Copy link
Member Author

Failed because master circe can't use the frozen cats version..

@dwijnand
Copy link
Member Author

the PR was off this repo, not your fork

That's only because that's what GitHub in-browser edit does, btw.

@SethTisue
Copy link
Member

[circe] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.9/project-builds/circe-9bc85a87699017ce9cfb8723435d194acd46af54/modules/core/shared/src/main/scala/io/circe/ArrayEncoder.scala:3:8: object Contravariant is not a member of package cats
[circe] [error] import cats.Contravariant
[circe] [error]        ^

from the cats 1.0-MF -> 1.0-RC release notes:

  • Profunctor and Strong were moved to the cats.arrow package, Bifunctor, Invariant and Contravariant were moved to the cats root package."

so this can wait until we push the cats 1.0 upgrade through the entire community build

@SethTisue
Copy link
Member

the cats 1.0 move has been on my mind for a while, but it has a ticket now: #653

@dwijnand
Copy link
Member Author

Let's call this one "blocked on #653".

@dwijnand dwijnand closed this Dec 18, 2017
@dwijnand dwijnand deleted the master-circe branch December 18, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants