Skip to content

Implicit DOMTokenList to Seq (e.g. for Element.classList) support #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Implicit DOMTokenList to Seq (e.g. for Element.classList) support #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769a85d
Implicit DOMTokenList to Seq (e.g. for Element.classList) support
abdolence Jun 22, 2019
40d54fa
Formatting fix
abdolence Jun 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/scala/org/scalajs/dom/ext/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ package object ext {
implicit class PimpedNodeList(nodes: NodeList)
extends EasySeq[Node](nodes.length, nodes.apply)

implicit class PimpedDOMTokenList(nodes: DOMTokenList)
Copy link
Contributor

@exoego exoego Aug 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming Pimped~ classes into Enrich~ or such, in subsequent PRs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% but let's perform this change on the upcoming 2.x release branch so we don't break compatibility

extends EasySeq[String](nodes.length, nodes.apply)

implicit class PimpedTouchList(nodes: TouchList)
extends EasySeq[Touch](nodes.length, nodes.apply)

Expand Down