Implicit DOMTokenList to Seq (e.g. for Element.classList) support #371
Conversation
armanbilge
force-pushed
the
domtokenlist-implicit-conversation
branch
from
6732dfa to
40d54fa
Compare
| @@ -9,6 +9,9 @@ package object ext { | |||
| implicit class PimpedNodeList(nodes: NodeList) | |||
| extends EasySeq[Node](nodes.length, nodes.apply) | |||
|
|
|||
| implicit class PimpedDOMTokenList(nodes: DOMTokenList) | |||
There was a problem hiding this comment.
How about renaming Pimped~ classes into Enrich~ or such, in subsequent PRs?
There was a problem hiding this comment.
100% but let's perform this change on the upcoming 2.x release branch so we don't break compatibility
|
This PR exists since 2019, probably high time to resolve it somehow? |
|
So sorry for that, we are working on it! See https://users.scala-lang.org/t/scala-js-dom-to-become-more-active-2-x-coming-soon/7702 |
Can't wait when you release it for Scala 3 as well 🎉 Thanks. No worries, it is generally just a small inconvenience to copy my implicits from one project to another :) |
|
For 2.x, in #458, I made those things available by default for all |
This confirms that #371 is no longer needed.
|
Thanks for the PR (and your patience!) @abdolence . This is fixed on |
Probably it was accidentally forgotten and it will be convenient to have something like Element.classList.foreach or filter additionally to the others.
Don't you think?