Skip to content

Add navigator.mediaDevices.getUserMedia(), deprecate old method #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Add navigator.mediaDevices.getUserMedia(), deprecate old method #342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50ee72c
Add `navigator.mediaDevices.getUserMedia()`, deprecate old method
rtyley Nov 29, 2018
9e7fda3
Corrections to scaladoc and method declaration as reviewed by Sébastien
rtyley Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/main/scala/org/scalajs/dom/experimental/webrtc/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,23 @@ package object webrtc {
@js.native
trait NavigatorMediaStream extends js.Object {

/**
* The MediaDevices getUserMedia() method prompts the user for permission to use a media input
* which produces a MediaStream with tracks containing the requested types of media. That stream
* can include, for example, a video track (produced by either a hardware or virtual video source
* such as a camera, video recording device, screen sharing service, and so forth), an audio track
* (similarly, produced by a physical or virtual audio source like a microphone, A/D converter, or
* the like), and possibly other track types.
*
* MDN
*
* @see [[https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia]]
*/
def mediaDevices: MediaDevices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Scaladoc does not correspond to this member. You took the one from MediaDevices but it should be the one from Navigator.mediaDevices.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be best to add = js.native to that method, so that it is not considered as abstract. This is what we typically do for interfaces that are actually implemented natively by the DOM.


@deprecated(
"Navigator.getUserMedia() is deprecated, use Navigator.mediaDevices.getUserMedia() instead.",
"2014-05-28")
def getUserMedia(constraints: MediaStreamConstraints,
success: js.Function1[MediaStream, Any],
error: js.Function1[DOMError, Any]): Unit = js.native
Expand Down