Add navigator.mediaDevices.getUserMedia(), deprecate old method
#342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `navigator.getUserMedia()` method is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getUserMedia ...and in fact during hacking [1], I found that I could gain Firefox support just by using the `navigator.mediaDevices.getUserMedia()` method instead, which is documented as having good cross-browser support: https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia#Browser_compatibility The deprecation seems to have occurred around 28th May 2014: w3c/mediacapture-main@de3bdaf#diff-ea76d38900f79cfae8f60e5f7cf16dd1R2755 [1] https://twitter.com/rtyley/status/1067815067780087808
sjrd
requested changes
Nov 29, 2018
| * | ||
| * @see [[https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia]] | ||
| */ | ||
| def mediaDevices: MediaDevices |
There was a problem hiding this comment.
The Scaladoc does not correspond to this member. You took the one from MediaDevices but it should be the one from Navigator.mediaDevices.
There was a problem hiding this comment.
It would also be best to add = js.native to that method, so that it is not considered as abstract. This is what we typically do for interfaces that are actually implemented natively by the DOM.
|
Thank you - it's a pleasure using scalajs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
navigator.getUserMedia()method is deprecated, and in fact during our hackday, I found that I could gain Firefox support just by using thenavigator.mediaDevices.getUserMedia()method instead, which is documented as having good cross-browser support. The deprecation seems to have occurred around 28th May 2014.