Skip to content

Fix #327: Add HTMLElement.dataset #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fix #327: Add HTMLElement.dataset #337

merged 1 commit into from
Mar 5, 2019

Conversation

bpholt
Copy link
Contributor

@bpholt bpholt commented Jul 23, 2018

fixes #327

@fdietze
Copy link
Contributor

fdietze commented Feb 3, 2019

What prevents this PR from being merged?

@sjrd sjrd changed the title add support for dataset to HTMLElement Add HTMLElement.dataset Mar 5, 2019
sjrd
sjrd approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the very long delay on this.

@sjrd sjrd changed the title Add HTMLElement.dataset Fix #327: Add HTMLElement.dataset Mar 5, 2019
@sjrd sjrd merged commit ef1f303 into scala-js:master Mar 5, 2019
@bpholt bpholt deleted the dataset branch April 24, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requesting HTMLElement.dataset
3 participants
@bpholt @fdietze @sjrd