Skip to content

requesting HTMLElement.dataset #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thari opened this issue May 8, 2018 · 1 comment · Fixed by #337
Closed

requesting HTMLElement.dataset #327

thari opened this issue May 8, 2018 · 1 comment · Fixed by #337

Comments

@thari
Copy link

thari commented May 8, 2018

I think HTMLElement.dataset is now supported by most browsers. Can you please add it as part of scala-js-dom facade.

Stack Overflow: https://stackoverflow.com/questions/34758423/using-element-dataset-in-scalajs
@sjrd
Copy link
Member

sjrd commented May 8, 2018

PR welcome ☺

bpholt added a commit to bpholt/scala-js-dom that referenced this issue Jul 23, 2018
@bpholt
add support for dataset to HTMLElement (fixes scala-js#327)
e82d743
@bpholt bpholt mentioned this issue Jul 23, 2018
Merged
@sjrd sjrd closed this as completed in #337 Mar 5, 2019
sjrd pushed a commit that referenced this issue Mar 5, 2019
@bpholt @sjrd
Fix #327: Add HTMLElement.dataset (#337)
ef1f303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #327: Add HTMLElement.dataset bpholt/scala-js-dom
2 participants
@sjrd @thari