Skip to content

Clipboard events: Fix signatures and add comments #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2018
Merged

Clipboard events: Fix signatures and add comments #314

merged 2 commits into from
Mar 11, 2018

Conversation

tindzk
Copy link
Contributor

@tindzk tindzk commented Feb 25, 2018

This pull request deprecates #220.

@tindzk tindzk changed the title Fix signatures and document clipboard events Clipboard events: Fix signatures and add comments Feb 25, 2018
tindzk added a commit to sparsetech/pine that referenced this pull request Feb 25, 2018
@tindzk
Implicits: Fix signatures of cut, copy and paste
ea37bdb 
See also scala-js/scala-js-dom#314
@sjrd
Copy link
Member

sjrd commented Mar 5, 2018

Travis did not like it:

[info] Main Scala API documentation to /home/travis/build/scala-js/scala-js-dom/target/scala-2.10/api...
model contains 843 documentable templates
[error] /home/travis/build/scala-js/scala-js-dom/src/main/scala/org/scalajs/dom/raw/lib.scala:780: Could not find any member to link for "org.scalajs.dom.document.execCommand".
[error]   /**
[error]   ^
[error] one error found
[error] (root/compile:doc) Scaladoc generation failed

@tindzk
Copy link
Contributor Author

tindzk commented Mar 11, 2018

Thanks, @sjrd. I fixed the comment and the checks now pass.

sjrd
sjrd approved these changes Mar 11, 2018
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sjrd sjrd merged commit 9f681a9 into scala-js:master Mar 11, 2018
@tindzk tindzk deleted the clipboard branch March 12, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tindzk @sjrd