Skip to content

Fix signatures for oncut, oncopy and onpaste #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix signatures for oncut, oncopy and onpaste #220

wants to merge 1 commit into from

Conversation

swhgoon
Copy link
Contributor

@swhgoon swhgoon commented Apr 9, 2016 •
edited
Loading

Fix signatures for oncut, oncopy and onpaste.

@swhgoon
Update lib.scala
b273f86 
oncut,oncopy,onpaste: ClipboardEvent?
@mseddon
Copy link
Contributor

mseddon commented Apr 9, 2016

(facepalm) I have no idea how they got that type.. LGTM.

@swhgoon swhgoon closed this Apr 10, 2016
@swhgoon swhgoon deleted the patch-1 branch April 10, 2016 13:46
@mseddon
Copy link
Contributor

mseddon commented Apr 10, 2016

@swhgoon was that intentional? The PR seems fine to me...

@swhgoon
Copy link
Contributor Author

swhgoon commented Apr 15, 2016

@mseddon I used dom.document.addEventListener("copy", fn) instead...

@swhgoon swhgoon restored the patch-1 branch April 15, 2016 01:47
@swhgoon swhgoon reopened this Apr 15, 2016
@mseddon
Copy link
Contributor

mseddon commented Apr 15, 2016

Ah, the only thing is, if you could reword your commit message to something more meaningful like "Fix signatures for oncut, oncopy and onpaste." and @sjrd will merge. Thanks!

@swhgoon swhgoon changed the title Update lib.scala Fix signatures for oncut, oncopy and onpaste Apr 18, 2016
@sjrd
Copy link
Member

sjrd commented Apr 18, 2016

@swhgoon : @mseddon meant the title of the commit. It's good to change the title of the PR, too, but most importantly it's the commit title that matters. You can edit it easily with git commit --amend while the branch of this PR is checked out.

@tindzk tindzk mentioned this pull request Feb 25, 2018
Merged
@sjrd
Copy link
Member

sjrd commented Mar 14, 2018

This ended up being done in 9bb10dc.

@sjrd sjrd closed this Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swhgoon @mseddon @sjrd