Skip to content

Conversation

@berndfinger
Copy link
Member

@berndfinger berndfinger commented Feb 17, 2025

In this commit, the file changelogs/changelog.yml is being reformatted, to comply with the standards as published in
https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelogs.md and
https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelog.yaml-format.md .

The command:

antsibull-changelog lint-changelog-yaml changelogs/changelog.yaml

returns with return code 0.

The command:

antsibull-changelog generate

generates the file CHANGELOG.rst from file changelogs/changelog.yaml. The file CHANGELOG.rst is also part of this commit.

Note: The subsections under changes: reflect the semver versioning scheme and try to follow the section descriptions in https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelogs.md. So there are only major changes when the first part of the version changes, and only minor changes when the second part of the version changes. If only the third part of the version changes, no minor changes will be mentioned in the changelog.

Certain minor changes could as well have been marked as major changes (thus justifying a major release), or certain bugfixes could as well have been minor changes or features (thus justifying a minor release).

Fixes issue #503.

In this commit, the file changelogs/changelog.yml is being reformatted
to comply with the standards as published in
https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelogs.md
and
https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelog.yaml-format.md
.

The command:

```
antsibull-changelog lint-changelog-yaml changelogs/changelog.yaml
```

returns with return code 0.

The command:

```
antsibull-changelog generate
```

generates the file CHANGELOG.rst from file changelogs/changelog.yaml.
The file CHANGELOG.rst is also part of this commit.

Signed-off-by: Bernd Finger <[email protected]>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks so much cleaner and dictionary use is way to go.

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berndfinger berndfinger merged commit 243b84d into sap-linuxlab:dev Feb 18, 2025
3 checks passed
@berndfinger berndfinger deleted the issue-503-changelog branch February 18, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants