-
Notifications
You must be signed in to change notification settings - Fork 11
merge dev to main for release 1.1.2 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sap_vm_provision/sap_vm_temp_vip: Feat: Add dynamic group handling for provisioning
sap_vm_verify: stub code comments and reorder
sap_vm_provision: update ms az req
In this commit, the file changelogs/changelog.yml has been manually created from the existing file CHANGELOG.rst and it complies with the standards as published in https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelogs.md and https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelog.yaml-format.md . The command: ``` antsibull-changelog lint-changelog-yaml changelogs/changelog.yaml ``` returns with return code 0. The command: ``` antsibull-changelog generate ``` generates the file CHANGELOG.rst from file changelogs/changelog.yaml. The file CHANGELOG.rst is also part of this commit. Solves #83. Signed-off-by: Bernd Finger <[email protected]>
collection: Implement file changeslogs/changelog.yaml
Signed-off-by: Bernd Finger <[email protected]>
collection: prepare for release 1.1.2
sean-freeman
approved these changes
Feb 19, 2025
Member
sean-freeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
marcelmamula
approved these changes
Feb 19, 2025
Contributor
marcelmamula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
newkit
approved these changes
Feb 19, 2025
Member
newkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4.6.0 is pretty new, so let's take 4.5.0 for now. Signed-off-by: Bernd Finger <[email protected]>
collection: Bump vmware.vmware_rest to 4.5.0
Fixes issue #89. Signed-off-by: Bernd Finger <[email protected]>
sap_vm_provision: Use amazon.aws.ec2_placement_group
sap_vm_provision: AWS tag pacemaker for fence agent stonith:external/ec2
Signed-off-by: Bernd Finger <[email protected]>
collection: Update the changelog after the recent PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.