sap_vm_provision/sap_vm_temp_vip: Feat: Add dynamic group handling for provisioning

[marcelmamula]

Changes

• Add new variables sap_vm_provision_group_* for sap_vm_provision to customize group names
• Add new variables sap_vm_temp_vip_group_* for sap_vm_temp_vip to customize group names
• Update all group[''] conditionals and loops to use new variables

NOTE 1: This does not require any change in AP4S as it adds way to customize provisioning, while retaining previous functionality.

@sean-freeman NOTE 2: Terraform tf_template_* files were not changed, because their hardcoded groups are commented out and unused. If it was need to use in future, we would need to switch to jinja template to fill in variable input into terraform files instead of direct copy.

Test results

All changes were tested with SLES4SAP 15 SP6 on following platforms:

• AWS
• AZ
• GCP

Tested scenarios:

• SAP HANA HA
• SAP ASCS/ERS HA

[ja9fuchs]

Review ongoing...

[ja9fuchs]

@marcelmamula Due to the direct relationship of the groups to the sap_host_type host specification dict value, can you confirm that this type is intended to change to the custom group name?
Otherwise many conditionals that match the group name in this parameter would not work, if I am not mistaken. Did you test with the existing default sap_host_type values and custom group names and it worked?

[ja9fuchs]

The role of sap_host_type has been clarified.

The change looks good to me, it only replaces hard-coded names with variables.

[marcelmamula]

@marcelmamula Due to the direct relationship of the groups to the sap_host_type host specification dict value, can you confirm that this type is intended to change to the custom group name? Otherwise many conditionals that match the group name in this parameter would not work, if I am not mistaken. Did you test with the existing default sap_host_type values and custom group names and it worked?

@ja9fuchs Providing my explanation to keep this in reply as well.
You are correct and I reflected it in readme as well.
previously: sap_host_type is one out of hana_primary, hana_secondary, nwas_ascs, nwas_ers, nwas_pas, nwas_aas, anydb_primary, anydb_secondary

now: sap_host_type can be any value that you define in corresponding sap_vm_provision_group_* variables, which be picked during workflow and compared against sap_host_type

sap_host_type is required, because you use that dictionary to define final system layout and if you did not have it, then groups would never be established to drive further logic that decides what goes where

[sean-freeman]

Will not test, trust the team 👍

All the same, for Ansible > Terraform I confirm this change will not impact bottom Terraform level logic, as it is just a passthrough of the data from the upper Ansible level:
https://github.com/sap-linuxlab/community.sap_infrastructure/blob/main/roles/sap_vm_provision/tasks/platform_ansible_to_terraform/aws_ec2_vs/tf_template/tf_template_outputs.tf#L8

[sean-freeman]

lgtm 👍