Fix tests with singular 4.3.2p4 #36018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Documentation preview for this PR (built with commit 7caf95b; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 23, 2023
sagemathgh-36018: Fix tests with singular 4.3.2p4 Due to changes in the output of `hilb` in singular 4.3.2p4 (it now outputs a polynomial instead of a list of monomials and coefficients to debug), some tests are failing. Additionally, the problematic `hilbert_numerator` example now correctly throws an overflow error instead of giving a wrong answer. We mark it as `known bug` so the test passes with older versions of singular, the label can be removed once we require 4.3.2p4. URL: sagemath#36018 Reported by: Antonio Rojas Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 1, 2023
sagemathgh-35934: build/pkgs/singular: Upgrade to 4.3.2p7, reject system Singular without FLINT <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - Resolves sagemath#35676 - Resolves sagemath#35273 - Resolves sagemath#35833 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#36018 (merged here) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35934 Reported by: Matthias Köppe Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in the output of
hilbin singular 4.3.2p4 (it now outputs a polynomial instead of a list of monomials and coefficients to debug), some tests are failing.Additionally, the problematic
hilbert_numeratorexample now correctly throws an overflow error instead of giving a wrong answer. We mark it asknown bugso the test passes with older versions of singular, the label can be removed once we require 4.3.2p4.