update Singular spkg to 4.3.2+

[dimpase]

Is there an existing issue for this?

• I have searched the existing issues for a bug report that matches the one I want to file, without success.

Problem Description

currently we ship 4.3.1 with patches, the latest is 4.3.2p1

Experiments indicate that 4.3.2 will need work, though.

Proposed Solution

do the work

Alternatives Considered

n/a

Additional Information

No response

[antonio-rojas]

I wasn't aware of tht 4.3.2p1 tag, as there is no corresponging tarballs in their server. Do you know if they're planning to release from github from now on, or is it just going to be random?

[antonio-rojas]

Updated downstream, there are no new issues that need fixing in sagelib compared to the current 4.3.1p3 version.

The only problem is that they don't provide a source tarball, so it needs to be downloaded from github and docs need to be built from source. Depending on the texinfo version used at build time, this can cause issues when Sage tries to parse the info file.

I've opened #35678 to handle this.

[dimpase]

I've asked whether there will be an official source tarball for 4.3.2p1: Singular/Singular#1175

[dimpase]

@antonio-rojas https://www.singular.uni-kl.de/ftp/pub/Math/Singular/SOURCES/4-3-2/ now contains 4.3.2p1 and p2.

[antonio-rojas]

4.3.2p2 is broken

Singular/Singular#1176

[tornaria]

After fixing 4.3.2p2 with Singular/Singular@8d54773, I get:

sage -t --random-seed=129530826087015995108246630021130802663 src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py
**********************************************************************
File "src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py", line 1254, in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.leinartas_decomposition
Failed example:
    decomp
Expected:
    (0, []) +
    (-(x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x)*y, [(y, 1)]) +
    ((x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x)*x*y, [(x*y + 1, 1)]) +
    (x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x, [(y, 1), (x, 1)])
Got:
    (0, []) + (-(x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x)*x, [(x, 1)]) + ((x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x)*x*y, [(x*y + 1, 1)]) + (x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x, [(y, 1), (x, 1)])
**********************************************************************
File "src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py", line 1613, in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.?
Failed example:
    decomp = F.asymptotic_decomposition(alpha); decomp
Expected:
    (0, []) +
    (16*r*(3/x - 2/z) + 16/x - 16/z,
     [(x + 2*y + z - 4, 1), (2*x + y + z - 4, 1)])
Got:
    (0, []) + (16*r*(2/x - 1/y) + 32/3/x - 16/3/y, [(x + 2*y + z - 4, 1), (2*x + y + z - 4, 1)])
**********************************************************************
2 items had failures:
   1 of  96 in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.?
   1 of  32 in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.leinartas_decomposition
    [793 tests, 2 failures, 4.94 s]
----------------------------------------------------------------------
sage -t --random-seed=129530826087015995108246630021130802663 src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py  # 2 doctests failed
----------------------------------------------------------------------

[kiwifb]

I can confirm 4.3.2_p1 does work and do not break any tests here. I probably will not get to play with _p2 if I wait for it in Gentoo main tree. If install is broken we may wait for _p3 or 4.3.3 whichever comes first.

[tornaria]

I tracked the first doctest failure down to

sage: R.<x,y> = PolynomialRing(QQ)
sage: J = R.ideal([x, y, x*y + 1])
sage: R.one().lift(J)  # with singular 4.3.2p1
[-y, 0, 1]
sage: R.one().lift()  # with singular 4.3.2p2
[0, -x, 1]

The second doctest failure seems to arise from something similar since the output goes through a Leinartas decomposition at some point.

Easy fix:

--- a/src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py
+++ b/src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py
@@ -1251,7 +1251,7 @@ class FractionWithFactoredDenominator(RingElement):
             sage: H = R(f.denominator())
             sage: ff = FFPD(G, H.factor())
             sage: decomp = ff.leinartas_decomposition()
-            sage: decomp
+            sage: decomp  # random - non canonical depends on singular version
             (0, []) +
             (-(x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x)*y, [(y, 1)]) +
             ((x*y^2*sin(x) + x^2*y + x*y + y*sin(x) + x)*x*y, [(x*y + 1, 1)]) +
@@ -1611,9 +1611,7 @@ class FractionWithFactoredDenominator(RingElement):
             (-16, [(x + 2*y + z - 4, 1), (2*x + y + z - 4, 2)])
             sage: alpha = [3, 3, 2]
             sage: decomp = F.asymptotic_decomposition(alpha); decomp
-            (0, []) +
-            (16*r*(3/x - 2/z) + 16/x - 16/z,
-             [(x + 2*y + z - 4, 1), (2*x + y + z - 4, 1)])
+            (0, []) + (..., [(x + 2*y + z - 4, 1), (2*x + y + z - 4, 1)])
             sage: F1 = decomp[1]
             sage: p = {x: 1, y: 1, z: 1}
             sage: asy = F1.asymptotics(p, alpha, 2, verbose=True) # long time

Note that the first test then goes on to check the computed decomposition actually satisfies the definition. And the second test is for asymptotics which is still tested.

[kiwifb]

Really, in the first case since there is a check that the result is correct, we do not need to display and check that output. The fact that it is consistent should be enough. And I do not really think we should display decomp in the second case either, it is just an intermediate result.

[jhpalmieri]

On OS X, homebrew's Singular 4.3.2p2 causes several doctest failures — see #35273. Has anyone tested out p1 or building your own p2 on OS X to see if those failures are present?