Skip to content

Fix WebAssembly Atomic intrinsic names #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

nat-rix
Copy link
Contributor

@nat-rix nat-rix commented Mar 20, 2021

An error was introduced in #1073 in changing the atomic intrinsic to memory.atomic.wait.iXX instead of memory.atomic.waitXX.
See also the commit 902ea58 in the llvm project

r? @alexcrichton

Due to commit 902ea588eab849e7254d3bc76abf32d833ac0dd6 in the
llvm-project i32.atomic.wait and i64.atomic.wait got renamed to
memory.atomic.wait32 and memory.atomic.wait64.
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

We really need to figure out how to test these on CI...

@Amanieu Amanieu merged commit 5a5137a into rust-lang:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants