Update WebAssembly SIMD/Atomics #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
wasm-sync
branch
2 times, most recently
from
a443ac5 to
9100b8d
Compare
This commit syncs the atomics/simd intrinsics used on WebAssembly with LLVM 12 and the current specifications. LLVM 12 uses new names for atomic intrinsics and the SIMD specification has added a lot of intrinsics and renamed a few as well. I was hoping to hold off on this until more of SIMD had landed since there are some opcode renumberings that have happened at the spec level but haven't happened in LLVM. Additionally there's a small handful of instructions that have yet to be implemented in LLVM. This means that many tests for the simd128 feature are ignored right now and/or are known to not pass. The breakage in the name of the atomic intrinsics, however, has prompted me to want to update this and land ahead of time. For now I've disabled the SIMD testing and I'll get back to it once things have settled a bit more with LLVM and runtimes.
|
I had a quick look and it still looks very much like a WIP, so I won't do an in-depth review. Still merging it since it fixes WASM intrinsics on LLVM 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit syncs the atomics/simd intrinsics used on WebAssembly with
LLVM 12 and the current specifications. LLVM 12 uses new names for
atomic intrinsics and the SIMD specification has added a lot of
intrinsics and renamed a few as well.
I was hoping to hold off on this until more of SIMD had landed since
there are some opcode renumberings that have happened at the spec level
but haven't happened in LLVM. Additionally there's a small handful of
instructions that have yet to be implemented in LLVM. This means that
many tests for the simd128 feature are ignored right now and/or are
known to not pass. The breakage in the name of the atomic intrinsics,
however, has prompted me to want to update this and land ahead of time.
For now I've disabled the SIMD testing and I'll get back to it once
things have settled a bit more with LLVM and runtimes.