Impl PartialEq/Ord<str/String> for Path[Buf] #31861
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for revisiting this: when preparing #31751 I was still assuming that the
<str>
impls are already there. So currentlyOsStr
can be compared tostr
andPath
cannot. This seems both inconsistent and inconvenient.I'm likely blind to some drawbacks and/or going over the top with combinations here. Could some of them be replaced with blanket impls for
T: AsRef<Path>
?It would help if there was a coordinating issue for
libstd
trait impls with some goals, dos and don'ts.